Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_make_schema fix #99

Closed
wants to merge 1 commit into from
Closed

Conversation

DtStry
Copy link
Collaborator

@DtStry DtStry commented Nov 7, 2022

No description provided.

@kmaphoenix
Copy link
Member

@DtStry can you provide some pointer code snippets to show how this was tested?

@DtStry
Copy link
Collaborator Author

DtStry commented Dec 5, 2022

@DtStry can you provide some pointer code snippets to show how this was tested?

I was simply calling bulk_create_intent_from_dataframe() with 'advanced' option and it throw this error
image

Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes proposed here are actually obsolete with the new data structure returned by Intents.bulk_intent_to_df(mode=advanced)

Instead of merging these in, the entire bulk_create_intent_from_dataframe needs to be refactored and/or reimagined. We should align all of our dataframe schemas appropriately so that the outputs of a method in one part of the library can be seamlessly used as inputs in another part of the library.

Since we have already refactored the DataFrame output in the Intents file, I suggest we realign here.

cc: @MRyderOC re: schema enforcements

@kmaphoenix
Copy link
Member

Closing this PR in lieu of the changes we've made to these files already.

@kmaphoenix kmaphoenix closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataframe_functions _make_schema concat dataframe with dictionary
2 participants