Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version number when running docker-credential-gcr version #155

Closed
obourgain opened this issue Nov 8, 2023 · 4 comments · Fixed by #176
Closed

Missing version number when running docker-credential-gcr version #155

obourgain opened this issue Nov 8, 2023 · 4 comments · Fixed by #176

Comments

@obourgain
Copy link

I just updated the binary to 2.1.19 and running
docker-credential-gcr version
prints

❯ docker-credential-gcr version
Google Container Registry Docker credential helper (devel)

while the previous version I had printed an actual version number

❯ docker-credential-gcr version
Google Container Registry Docker credential helper 2.1.0
@cbandy
Copy link

cbandy commented Oct 3, 2024

This is still the case, despite recent changes like #171.

$ curl -sLO 'https://github.com/GoogleCloudPlatform/docker-credential-gcr/releases/download/v2.1.25/checksums.txt'
$ curl -sLO 'https://github.com/GoogleCloudPlatform/docker-credential-gcr/releases/download/v2.1.25/docker-credential-gcr_darwin_arm64-2.1.25.tar.gz'
$ shasum -c checksums.txt
docker-credential-gcr_darwin_arm64-2.1.25.tar.gz: OK

$ tar xf docker-credential-gcr_darwin_arm64-2.1.25.tar.gz docker-credential-gcr
$ ./docker-credential-gcr version
Google Container Registry Docker credential helper (devel)

@rafibarash
Copy link
Contributor

Can you install via the go cli like so?

go install github.com/GoogleCloudPlatform/docker-credential-gcr/v2@latest

This isn't reproducible when installed with the above command

~
❯ rm ~/go/bin/docker-credential-gcr

~
❯ which docker-credential-gcr
docker-credential-gcr not found

~
❯ go install github.com/GoogleCloudPlatform/docker-credential-gcr/v2@latest

~
❯ which docker-credential-gcr
/Users/rbarash/go/bin/docker-credential-gcr

~
❯ docker-credential-gcr version
Google Container Registry Docker credential helper 2.1.25

I'll update the documentation with this installation instruction, it is a bit out of date and uses go get

@obourgain
Copy link
Author

yes, installing with go install prints the version 2.1.25, while the binary downloaded from the Github release assets print devel

@dsiebel
Copy link
Contributor

dsiebel commented Nov 13, 2024

I created a PR to address this (#176), maybe one of the maintainers could have a look
FYI @yihanzhen, @MeBaranov, ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants