ci: fix version output in version subcommand (release binaries)
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I signed the CLA a while ago, when contributing to https://github.com/GoogleContainerTools/skaffold. Looks like GitHub's email privacy settings break the detection... |
dsiebel
changed the title
version subcommandversion subcommand (release binaries)
yihanzhen
approved these changes
Nov 13, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
I noticed that
docker-credential-gcr versiondoes not print the correct version when downloaded from the release assets:In our case, this breaks idempotent installs in CI, because we can not detect any previously installed versions properly.
Having to install
gofirst to be able to installdocker-credential-gcrwould also waste valuable build time.Looking through the code I noticed that the
goreleaser.yamlconfig wasn't using the exactldflagsthat is mentioned in config/const.go. The config essentially references the wrong package.