use Pod informer to avoid Pod GET API calls #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songjiaxun
changed the title
saikat-royc
reviewed
Jun 17, 2024
saikat-royc
reviewed
Jun 17, 2024
saikat-royc
reviewed
Jun 27, 2024
saikat-royc
reviewed
Jun 27, 2024
saikat-royc
reviewed
Jun 27, 2024
|
looks good after the minor comments are addressed @hime is this tested? |
Hi @saikat-royc, we have tested this PR with informer. We saw that the pod get calls from gcsfuse are eliminated and the nodeselector is able to only track the pods that are assigned to that specific node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors
GetPodfunction to use Pod informer and lister to get Pod spec. This change avoids direct Pod GET API calls to increase the CSI node driver scalability.