Revert "temp commit containing failing cases"

This reverts commit b82f5f791b00b9b0b5f126eb93de5ec2db5d3b52.
GoogleCloudPlatform · Jul 12, 2024 · 7884bc5 · 7884bc5
1 parent 06163d7
commit 7884bc5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 64 deletions.
diff --git a/internal/fs/kernel_list_cache_inifinite_ttl_test.go b/internal/fs/kernel_list_cache_inifinite_ttl_test.go
@@ -147,35 +147,3 @@ func (t *KernelListCacheTestWithInfiniteTtl) TestKernelListCache_RemoveDirAfterL
 	require.Equal(t.T(), 1, len(names2))
 	assert.Equal(t.T(), "file4.txt", names2[0].Name())
 }
-
-//func (t *KernelListCacheTestWithInfiniteTtl) TestKernelListCache_RemoveDirWorksWhenNoLocalCachedFiles() {
-//	err := os.Mkdir(path.Join(mntDir, "newDir"), os.FileMode(0777))
-//	// First read, kernel will cache the dir response.
-//	f, err := os.Open(path.Join(mntDir, "newDir"))
-//	assert.Nil(t.T(), err)
-//	names1, err := f.Readdirnames(-1)
-//	assert.Nil(t.T(), err)
-//	require.Equal(t.T(), 0, len(names1))
-//	err = f.Close()
-//	assert.Nil(t.T(), err)
-//	// Adding one object to make sure to change the ReadDir() response.
-//	assert.Nil(t.T(), t.createObjects(map[string]string{
-//		"newDir/file1.txt": "123456",
-//	}))
-//
-//	// os.RemoveAll should delete all files and invalidate cache.
-//	err = os.RemoveAll(path.Join(mntDir, "newDir"))
-//	assert.NoError(t.T(), err)
-//
-//	//assert.NotNil(t.T(), err)
-//
-//	//err = os.RemoveAll(path.Join(mntDir, "newDir"))
-//	//assert.NoError(t.T(), err)
-//
-//	//names2, err := os.ReadDir(path.Join(mntDir, "newDir"))
-//	//assert.NoError(t.T(), err)
-//	//require.Equal(t.T(), 1, len(names2))
-//	//assert.Equal(t.T(), "file1.txt", names2[0].Name())
-//	//var pathError *os.PathError
-//	//assert.True(t.T(), errors.As(err, &pathError))
-//}
diff --git a/tools/integration_tests/kernel-list-cache/infinite_kernel_list_cache_test.go b/tools/integration_tests/kernel-list-cache/infinite_kernel_list_cache_test.go
@@ -258,38 +258,6 @@ func (s *infiniteKernelListCacheTest) TestKernelListCache_ListAndDeleteDirectory
 	require.NoError(t, err)
 }
 
-//func (s *infiniteKernelListCacheTest) TestKernelListCache_ListAndDeleteDirectoryContainingOnlyGCSFiles(t *testing.T) {
-//	targetDir := path.Join(testDirPath, "explicit_dir")
-//	operations.CreateDirectory(targetDir, t)
-//
-//	// (a) First read served from GCS, kernel will cache the dir response.
-//	f, err := os.Open(targetDir)
-//	assert.NoError(t, err)
-//	names1, err := f.Readdirnames(-1)
-//	assert.NoError(t, err)
-//	require.Equal(t, 0, len(names1))
-//	err = f.Close()
-//	assert.NoError(t, err)
-//
-//	// Adding one object to make sure to change the ReadDir() response.
-//	client.CreateObjectInGCSTestDir(ctx, storageClient, testDirName, path.Join("explicit_dir", "file3.txt"), "", t)
-//
-//	err = os.RemoveAll(targetDir)
-//	assert.NoError(t, err)
-//
-//	err = os.RemoveAll(targetDir)
-//	assert.NoError(t, err)
-//
-//	f, err = os.Open(targetDir)
-//	assert.NoError(t, err)
-//	names2, err := f.Readdirnames(-1)
-//	assert.NoError(t, err)
-//	require.Equal(t, 1, len(names2))
-//	err = f.Close()
-//	assert.NoError(t, err)
-//}
-//
-
 // explicit_dir/file1.txt
 // explicit_dir/sub_dir/file2.txt
 // explicit_dir/sub_dir/file3.txt