Parallel download read cache #1962
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethiay
force-pushed
the
parallel_download_read_cache
branch
from
62eee6d
to
b93aab2
Compare
sethiay
force-pushed
the
parallel_download_read_cache
branch
from
f5f9a0e
to
326fa8f
Compare
raj-prince
reviewed
Jun 4, 2024
| if start < end { | ||
| // Parallely download different ranges not more than ReadChunkSize and | ||
| // not using go routines more than AsyncDownloadParallelism | ||
| asyncDownloaderErrors := make([]error, job.downloadParallelism) |
There was a problem hiding this comment.
Instead, we should use ErrGroup: https://medium.com/@yardenlaif/go-sync-or-go-home-errgroup-f91a0ee72d3f
(a) No need to maintain error of all the go-routines.
(b) Abort if any of the go routine returns error and returns the first error (if multiple go routines returns error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assumptions: If there is a file of size S bytes already present then it is safe for multiple threads to write into disjoint sets of ranges into the same file where each thread has its own file handle.
Link to the issue in case of a bug fix.
NA
Testing details