Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder metadata in stat cache #2097

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ankitaluthra1
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 commented Jul 4, 2024

Description

Adds insertFolder, AddNegativeEntryForFolder and lookup folder in stat cache for HNS buckets.
This PR only adds new methods with corresponding implementations, currently these are not called from any bucket type.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Done
  3. Integration tests - NA

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 47.29730% with 39 lines in your changes missing coverage. Please review.

Project coverage is 71.44%. Comparing base (ede5064) to head (bd07899).
Report is 7 commits behind head on master.

Files Patch % Lines
...storage/caching/mock_gcscaching/mock_stat_cache.go 0.00% 35 Missing ⚠️
internal/cache/metadata/stat_cache.go 89.74% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
- Coverage   72.23%   71.44%   -0.80%     
==========================================
  Files         101      101              
  Lines       10956    12175    +1219     
==========================================
+ Hits         7914     8698     +784     
- Misses       2713     3117     +404     
- Partials      329      360      +31     
Flag Coverage Δ
unittests 71.44% <47.29%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tulsishah
Tulsishah previously approved these changes Jul 4, 2024
Tulsishah
Tulsishah previously approved these changes Jul 5, 2024
Tulsishah
Tulsishah previously approved these changes Jul 5, 2024
internal/cache/metadata/stat_cache.go Outdated Show resolved Hide resolved
internal/cache/metadata/stat_cache.go Outdated Show resolved Hide resolved
internal/cache/metadata/stat_cache.go Outdated Show resolved Hide resolved
internal/cache/metadata/stat_cache_test.go Outdated Show resolved Hide resolved
internal/cache/metadata/stat_cache_test.go Show resolved Hide resolved
internal/cache/metadata/stat_cache_test.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants