Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rename folder 3 #2102

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Implement rename folder 3 #2102

merged 4 commits into from
Jul 5, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jul 4, 2024

Description

  • Fake bucket implementation for rename folder
  • Fix Get folder fake bucket implementation(It was not returning error if folder does not exist)
  • Created rename folder test in prefix_bucket_test.
  • Fix some TODOs. GetFolder API instead of statObject in prefix_bucket_tests.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 6.06061% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (f5fbf04) to head (7e35f80).
Report is 1 commits behind head on master.

Files Patch % Lines
internal/storage/fake/bucket.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2102      +/-   ##
==========================================
- Coverage   72.02%   71.91%   -0.12%     
==========================================
  Files         101      101              
  Lines       11000    11029      +29     
==========================================
+ Hits         7923     7931       +8     
- Misses       2749     2771      +22     
+ Partials      328      327       -1     
Flag Coverage Δ
unittests 71.91% <6.06%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review July 4, 2024 13:25
@Tulsishah Tulsishah requested a review from a team as a code owner July 4, 2024 13:25
@Tulsishah Tulsishah requested review from raj-prince, ankitaluthra1 and charith87 and removed request for raj-prince July 4, 2024 13:25
@Tulsishah Tulsishah merged commit f2107c6 into master Jul 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants