Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to convert controlpb.folder attributes to gcs.Folder #2139

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jul 10, 2024

Description

  • Function to convert controlpb.folder attribute to gcs.Folder as it will required in many places.
  • In HNS, folder paths returned by control client APIs are in the form of: projects/_/buckets/{bucket}/folders/{folder}
    Introduced method extracts the folder name from such a string.
    e.g.
    control client GetFolder(folder1/folder2) returns folder Name as projects/_/buckets/{bucket}/folders/folder1/folder2
    We will fetch folder1/folder2 from response and set it in folder attribute.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (f788ddd) to head (dfd24be).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
+ Coverage   71.93%   71.95%   +0.01%     
==========================================
  Files         101      102       +1     
  Lines       11125    11131       +6     
==========================================
+ Hits         8003     8009       +6     
  Misses       2792     2792              
  Partials      330      330              
Flag Coverage Δ
unittests 71.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah changed the title Fetch folder name from control client API response name attribute. Function to convert controlpb.folder attributes to gcs.Folder Jul 11, 2024
@Tulsishah Tulsishah marked this pull request as ready for review July 11, 2024 02:35
@Tulsishah Tulsishah requested a review from a team as a code owner July 11, 2024 02:35
ankitaluthra1
ankitaluthra1 previously approved these changes Jul 12, 2024
charith87
charith87 previously approved these changes Jul 12, 2024
Copy link
Collaborator

@charith87 charith87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only added nit comments. So approving the review.

@Tulsishah Tulsishah dismissed stale reviews from charith87 and ankitaluthra1 via 575a197 July 12, 2024 11:34
@Tulsishah Tulsishah requested a review from charith87 July 12, 2024 11:36
charith87
charith87 previously approved these changes Jul 12, 2024
@Tulsishah Tulsishah merged commit 8d72ea9 into master Jul 12, 2024
13 checks passed
@Tulsishah Tulsishah deleted the fetch_object_name_hns branch July 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants