-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function to convert controlpb.folder attributes to gcs.Folder #2139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
+ Coverage 71.93% 71.95% +0.01%
==========================================
Files 101 102 +1
Lines 11125 11131 +6
==========================================
+ Hits 8003 8009 +6
Misses 2792 2792
Partials 330 330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
58609f4
to
126ab80
Compare
81f5bae
to
3ebfe33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only added nit comments. So approving the review.
Description
projects/_/buckets/{bucket}/folders/{folder}
Introduced method extracts the folder name from such a string.
e.g.
control client GetFolder(
folder1/folder2
) returns folder Name asprojects/_/buckets/{bucket}/folders/folder1/folder2
We will fetch
folder1/folder2
from response and set it in folder attribute.Link to the issue in case of a bug fix.
NA
Testing details