GCVE Service Networking #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradSchieban
requested changes
Jul 31, 2023
| @@ -0,0 +1,119 @@ | |||
| # GCVE Private Cloud Module | |||
|
|
|||
| This module contains the terraform to create and deploy a private cloud | |||
There was a problem hiding this comment.
Added changes as per review
| source = "terraform-google-modules/gcloud/google" | ||
|
|
||
| platform = "linux" | ||
| additional_components = ["kubectl", "beta"] |
There was a problem hiding this comment.
do we actually need a dependency on kubectl?
There was a problem hiding this comment.
Added Changes as per review
| */ | ||
|
|
||
| terraform { | ||
| required_version = ">= 1.5.3" |
There was a problem hiding this comment.
shall we keep it at 1.3.0 which is the version we previously required for other modules. Seems odd that we suddenly have this jump. We may want to be consistent throughout the repo.
There was a problem hiding this comment.
Added changes as per review
KonradSchieban
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>