Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BackendService beta API tests #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kl52752
Copy link
Contributor

@kl52752 kl52752 commented Sep 10, 2024

Fields present in beta.BackendService API might be promoted to v1 any time and it is hard to follow that changes. Having a test that checks that fields are present only in beta API and checkst that conversion between Ga and Beta version fails are unstable and hard to maintain. Removing this logic from tests.

Fields present in beta.BackendService API might be promoted to v1 any time and
it is hard to follow that changes. Having a test that checks that fields are
present only in beta API and checkst that conversion between Ga and Beta version
fails are unstable and hard to maintain. Removing this logic from tests.
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kl52752
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kl52752
Copy link
Contributor Author

kl52752 commented Sep 10, 2024

/cc @AwesomePatrol

@bowei
Copy link
Member

bowei commented Sep 10, 2024

The whole point of the testing that conversion works is to make sure someone is paying attention and updates the code when the GA APIs are introduced.

What is the mitigation on how are we going to track a change if we remove the test?

@kl52752
Copy link
Contributor Author

kl52752 commented Sep 11, 2024

The problem with those test is that it is hard to maintain it across different version of API. The best way to test it is t really on e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants