Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service identity to generate P4SA in samples and tests for Vertex AI resources #1784

Merged

Conversation

jingyih
Copy link
Collaborator

@jingyih jingyih commented May 13, 2024

Avoid hard-coding P4SA service account in Vertex AI samples and tests.

TESTED

$ go test -v -tags=integration ./config/tests/samples/create/ -run-tests vertexai-dataset-encryptionkey

$ go test -v -tags=integration ./config/tests/samples/create/ -run-tests vertexai-endpoint-encryptionkey

$ go test -v -tags=integration ./pkg/controller/dynamic/ -test.run TestCreateNoChangeUpdateDelete -run-tests vertexaidatasetencryptionkey

$ go test -v -tags=integration ./pkg/controller/dynamic/ -test.run TestCreateNoChangeUpdateDelete -run-tests vertexaiendpointencryptionkey

@maqiuyujoyce
Copy link
Collaborator

/lgtm
/approve

Thank you for the quick fix!

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7678b60 into GoogleCloudPlatform:master May 14, 2024
11 checks passed
@yuwenma yuwenma added this to the 1.118 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants