Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip requirements file, pin versions and add hashes #1785

Merged

Conversation

barney-s
Copy link
Collaborator

@barney-s barney-s commented May 13, 2024

Change description

Pin pip package version with hashes
Use a requirements file

Docker build is failing with:

 Collecting pip
#7 2.263 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
#7 2.263     pip from https://files.pythonhosted.org/packages/8a/6a/19e9fe04fca059ccf770861c7d5721ab4c2aebc539889e97c7977528a53b/pip-24.0-py3-none-any.whl
#7 2.452 
#7 2.452 [notice] A new release of pip is available: 23.0.1 -> 24.0
#7 2.452 [notice] To update, run: pip install --upgrade pip
#7 ERROR: executor failed running [/bin/sh -c pip install --require-hashes --upgrade pip]: exit code: 1

@barney-s
Copy link
Collaborator Author

/lgtm
/approve

Copy link
Contributor

@barney-s: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cheftako
Copy link
Collaborator

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d17d769 into GoogleCloudPlatform:master May 14, 2024
11 checks passed
@barney-s barney-s deleted the fix_pip_install branch May 14, 2024 22:49
@yuwenma yuwenma added this to the 1.118 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants