-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests:chore: update for logbucketmetric #1795
Conversation
/hold want the base ref to merge first : acpana/test-reconcile-direct EDIT: add base ref acpana/test-reconcile-direct |
What's the base ref? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
One minor comment just for maintenance nit.
/approve |
68c43d2
to
8c4339e
Compare
5662151
to
ae3984b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Need further discussion about the skip update |
Signed-off-by: Alex Pana <[email protected]>
ae3984b
to
567f6cc
Compare
Added update.yaml and re-ran the test ✅ |
Regarding b/331421837, do we have any test to have the |
/hold cancel |
/lgtm |
Path adds update struct for
logbucketmetric
test.