Switch jinja2 to grpc based expansion #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barney-s
changed the title
barney-s
force-pushed
the
switch-jinja2-grpc
branch
8 times, most recently
from
3ee932d to
532f4e7
Compare
barney-s
changed the title
barney-s
force-pushed
the
switch-jinja2-grpc
branch
from
532f4e7 to
936ea11
Compare
xiaoweim
reviewed
May 29, 2024
experiments/compositions/composition/api/v1alpha1/expanderversion_types.go
Show resolved
Hide resolved
experiments/compositions/composition/config/expanders/expander_versions.yaml
Show resolved
Hide resolved
cheftako
reviewed
May 29, 2024
experiments/compositions/composition/config/expanders/expander_versions.yaml
Outdated
Show resolved
Hide resolved
- rename gjinjg2 -> jinja2 (making jinja2 grpc based)
- rename existing pod based jinja2 -> pjinja2
- Add `image` field to ExpanderVersion
- allow specifying an image that doesnt follow the
removePrefix(expanderversion.name , "composition-") pattern.
- provides more flexibility
- In our case the type is pjinja and the image is expander-jinja
- Add a custom ratelimiter for the facade reconciler
- Due to a bug, the reconciler is not restarted across tests.
- Old failures add to rate limiting causing random failures
- make ratelimiter max backoff 120s
- Add a small sleep b/w tests
- Move all ExistTimeout to CompositionReconcileTimeout
- Check if a plan was updated and if so check if the applier sees the
latest plan object. If not retry again.
- Add InputGeneration and Generation to plan status
barney-s
force-pushed
the
switch-jinja2-grpc
branch
from
936ea11 to
de42d6e
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 311592b
into
GoogleCloudPlatform:master
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Switch jinja2 to grpc based expansion:
imagefield to ExpanderVersionremovePrefix(expanderversion.name , "composition-") pattern.
latest plan object. If not retry again.