Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Spelling #3062

Open
wants to merge 219 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
219 commits
Select commit Hold shift + click to select a range
a9e2cb9
spelling: abandon
jsoref Oct 29, 2024
ea0de9a
spelling: accessible
jsoref Oct 28, 2024
6202431
spelling: account
jsoref Oct 28, 2024
2fe1c88
spelling: acquiring
jsoref Oct 28, 2024
37e73a7
spelling: actual
jsoref Oct 28, 2024
e7acd04
spelling: actuation
jsoref Oct 29, 2024
7db79b5
spelling: already
jsoref Oct 28, 2024
7282ed3
spelling: ambiguous
jsoref Oct 28, 2024
ee4468a
spelling: an
jsoref Oct 30, 2024
f312040
spelling: analyze
jsoref Oct 28, 2024
8a3fee9
spelling: and
jsoref Oct 28, 2024
8c3960a
spelling: annotation composition
jsoref Oct 29, 2024
f001367
spelling: annotation
jsoref Oct 28, 2024
2ec890c
spelling: associated
jsoref Oct 28, 2024
794cbae
spelling: asymptotic
jsoref Oct 30, 2024
f438d66
spelling: autopilot
jsoref Oct 28, 2024
c79138d
spelling: availability
jsoref Oct 28, 2024
9355b44
spelling: available
jsoref Oct 28, 2024
cab778a
spelling: behavior
jsoref Oct 28, 2024
f969935
spelling: being
jsoref Oct 28, 2024
9849768
spelling: billing
jsoref Oct 28, 2024
454523a
spelling: block
jsoref Oct 28, 2024
285c9d7
spelling: bring up
jsoref Oct 29, 2024
361062e
spelling: bring-up
jsoref Oct 29, 2024
c388d99
spelling: cannot
jsoref Oct 28, 2024
9caa743
spelling: case-insensitive
jsoref Oct 28, 2024
0303418
spelling: case-sensitive
jsoref Oct 28, 2024
0cb8f6d
spelling: characteristics
jsoref Oct 28, 2024
0666cd3
spelling: choice
jsoref Oct 28, 2024
b95745e
spelling: cleaning
jsoref Oct 28, 2024
5577462
spelling: compatibility
jsoref Oct 29, 2024
9de5a28
spelling: compilation
jsoref Oct 28, 2024
5c3ad87
spelling: composition
jsoref Oct 28, 2024
f1f5878
spelling: config
jsoref Oct 28, 2024
10602e2
spelling: configcap
jsoref Oct 29, 2024
b920d5b
spelling: configuration
jsoref Oct 28, 2024
15178ca
spelling: connection
jsoref Oct 28, 2024
fb0e2a8
spelling: connector
jsoref Oct 28, 2024
2a5cfce
spelling: controller
jsoref Oct 28, 2024
024cb8e
spelling: converting
jsoref Oct 28, 2024
2e67409
spelling: corresponding
jsoref Oct 28, 2024
3877b58
spelling: creating
jsoref Oct 28, 2024
88c9b39
spelling: customization
jsoref Oct 28, 2024
e2c5b86
spelling: database
jsoref Oct 28, 2024
59d4c42
spelling: defined
jsoref Oct 28, 2024
13294f0
spelling: definition
jsoref Oct 28, 2024
a72aa0a
spelling: delegate
jsoref Oct 28, 2024
3e12b62
spelling: delimit
jsoref Oct 28, 2024
48ed3bc
spelling: delimiter
jsoref Oct 28, 2024
8362149
spelling: dependency
jsoref Oct 28, 2024
2fc5bdf
spelling: deployments
jsoref Oct 28, 2024
46b95a7
spelling: deprecated
jsoref Oct 28, 2024
1edd881
spelling: describe
jsoref Oct 28, 2024
bc6fdb0
spelling: detection
jsoref Oct 28, 2024
c38d4ce
spelling: determining
jsoref Oct 28, 2024
56943e9
spelling: direct
jsoref Oct 28, 2024
db164e0
spelling: dockerfile
jsoref Oct 28, 2024
3d8c628
spelling: does not exist
jsoref Oct 28, 2024
9081099
spelling: duration
jsoref Oct 28, 2024
51ce5b2
spelling: dynamically
jsoref Oct 28, 2024
82ea06b
spelling: endpoint
jsoref Oct 28, 2024
be69c46
spelling: enforcement
jsoref Oct 28, 2024
a68bef1
spelling: equal
jsoref Oct 30, 2024
af71083
spelling: equals
jsoref Oct 30, 2024
fc2bfec
spelling: error
jsoref Oct 28, 2024
35d6711
spelling: etagstatus
jsoref Oct 28, 2024
ecec377
spelling: evaluated
jsoref Oct 28, 2024
296e0c1
spelling: every time
jsoref Oct 28, 2024
7524e23
spelling: example
jsoref Oct 28, 2024
8d1faa3
spelling: except
jsoref Oct 29, 2024
a86b996
spelling: exclusive
jsoref Oct 28, 2024
b68a2b7
spelling: expander
jsoref Oct 28, 2024
d0ce823
spelling: expected
jsoref Oct 28, 2024
49494d4
spelling: explicitly
jsoref Oct 28, 2024
77592ee
spelling: external
jsoref Oct 28, 2024
475ecf6
spelling: fields
jsoref Oct 31, 2024
c803595
spelling: flaky
jsoref Oct 28, 2024
d433500
spelling: following
jsoref Oct 28, 2024
11cd470
spelling: for
jsoref Oct 28, 2024
43f5f6c
spelling: forwarded
jsoref Oct 28, 2024
602f7cf
spelling: forwarding
jsoref Oct 29, 2024
ea4a461
spelling: generate
jsoref Oct 28, 2024
b10357e
spelling: generated
jsoref Oct 28, 2024
b6b1463
spelling: geo
jsoref Oct 29, 2024
d8534e0
spelling: github
jsoref Oct 28, 2024
3e816dc
spelling: greater
jsoref Oct 28, 2024
6b0b2aa
spelling: group
jsoref Oct 28, 2024
bd03fb0
spelling: hierarchical
jsoref Oct 28, 2024
41386b0
spelling: hierarchy
jsoref Oct 28, 2024
3611c6c
spelling: id
jsoref Oct 28, 2024
0535056
spelling: identifying
jsoref Oct 28, 2024
511094f
spelling: include
jsoref Oct 28, 2024
7f3420a
spelling: infinity
jsoref Oct 28, 2024
cab163e
spelling: inherited
jsoref Oct 28, 2024
7bcfb06
spelling: initializing
jsoref Oct 28, 2024
bf6abcb
spelling: instance
jsoref Oct 28, 2024
887c75b
spelling: interface
jsoref Oct 28, 2024
c33b6f7
spelling: into
jsoref Oct 28, 2024
3696492
spelling: invalidate
jsoref Oct 28, 2024
3544b7e
spelling: is strictly equal
jsoref Oct 30, 2024
b8c3bce
spelling: later on
jsoref Oct 28, 2024
ab48a2d
spelling: limitations
jsoref Oct 28, 2024
21d7bc5
spelling: loader
jsoref Oct 28, 2024
a2ac55e
spelling: loading
jsoref Oct 28, 2024
a2d8ca1
spelling: location
jsoref Oct 28, 2024
753b85b
spelling: locations
jsoref Oct 28, 2024
4b944b0
spelling: macos
jsoref Oct 29, 2024
36b4061
spelling: managed
jsoref Oct 28, 2024
2a4b440
spelling: manifests
jsoref Oct 28, 2024
af1daa6
spelling: mapping
jsoref Oct 29, 2024
2c2aeb5
spelling: marshalling
jsoref Oct 29, 2024
68bb231
spelling: mask
jsoref Oct 29, 2024
91db460
spelling: membership
jsoref Oct 30, 2024
d27464f
spelling: message
jsoref Oct 29, 2024
abcf68d
spelling: microsoft
jsoref Oct 30, 2024
4021520
spelling: mismatch
jsoref Oct 29, 2024
8d5d0d4
spelling: multiple
jsoref Oct 29, 2024
6a6e1dd
spelling: must iterate
jsoref Oct 31, 2024
0d20b82
spelling: name
jsoref Oct 29, 2024
c31b491
spelling: namespace
jsoref Oct 29, 2024
3923054
spelling: namespaced
jsoref Oct 29, 2024
132dcfb
spelling: network
jsoref Oct 28, 2024
6cf2aba
spelling: node
jsoref Oct 30, 2024
23b1f52
spelling: nonexistent
jsoref Oct 28, 2024
8b26dde
spelling: notification
jsoref Oct 29, 2024
df3b697
spelling: object
jsoref Oct 29, 2024
30c73b6
spelling: one
jsoref Oct 28, 2024
0d3bf2a
spelling: openshift
jsoref Oct 29, 2024
115febf
spelling: organization
jsoref Oct 29, 2024
e50fa86
spelling: output
jsoref Oct 29, 2024
6a28647
spelling: outputting
jsoref Oct 30, 2024
f6f1a12
spelling: override
jsoref Oct 30, 2024
bd711f2
spelling: packages
jsoref Oct 29, 2024
01c8f7c
spelling: parallelize
jsoref Oct 29, 2024
257bb1c
spelling: permanently
jsoref Oct 29, 2024
e2ea645
spelling: pluralization
jsoref Oct 29, 2024
cc5b8d1
spelling: preexisting
jsoref Oct 28, 2024
df8bffb
spelling: preferably
jsoref Oct 29, 2024
d52d5b3
spelling: prepopulate
jsoref Oct 28, 2024
eb0c8a8
spelling: prerequisite
jsoref Oct 28, 2024
8ffed6d
spelling: priority
jsoref Oct 29, 2024
55571a3
spelling: protocol
jsoref Oct 29, 2024
90a5ef8
spelling: pruning
jsoref Oct 29, 2024
c38616a
spelling: racy
jsoref Oct 29, 2024
00e688a
spelling: rate limiting
jsoref Oct 29, 2024
3f8c141
spelling: real
jsoref Oct 29, 2024
aa7b11f
spelling: reconciled
jsoref Oct 29, 2024
d6eff39
spelling: reconnect
jsoref Oct 29, 2024
ab520f5
spelling: recursively
jsoref Oct 29, 2024
faf85c8
spelling: reenqueue
jsoref Oct 29, 2024
36f587b
spelling: refresh
jsoref Oct 29, 2024
455f396
spelling: regular
jsoref Oct 29, 2024
ec74359
spelling: replicas
jsoref Oct 29, 2024
3bbfad2
spelling: repositories
jsoref Oct 30, 2024
95e0be9
spelling: repository
jsoref Oct 29, 2024
cbbd702
spelling: resource
jsoref Oct 29, 2024
b9beb0c
spelling: resources
jsoref Oct 29, 2024
af00bed
spelling: retries
jsoref Oct 28, 2024
93de95b
spelling: revision
jsoref Oct 29, 2024
8d1d829
spelling: routines
jsoref Oct 29, 2024
be2bd90
spelling: scheduled
jsoref Oct 29, 2024
5273968
spelling: schema
jsoref Nov 1, 2024
c43d5b4
spelling: security
jsoref Oct 29, 2024
8f671d7
spelling: sensitive
jsoref Oct 29, 2024
72f1964
spelling: separate
jsoref Oct 29, 2024
502db00
spelling: separator
jsoref Oct 29, 2024
dc3e891
spelling: service
jsoref Oct 29, 2024
e62ba4c
spelling: should-be
jsoref Oct 29, 2024
cb5f2f5
spelling: specified
jsoref Oct 29, 2024
9466188
spelling: specifies
jsoref Oct 29, 2024
4d48677
spelling: ssd
jsoref Oct 28, 2024
274c13b
spelling: succeeded
jsoref Oct 29, 2024
f45a70b
spelling: successfully
jsoref Oct 29, 2024
469752d
spelling: supported
jsoref Oct 29, 2024
0f8259a
spelling: supporting
jsoref Oct 31, 2024
266ff87
spelling: surfaced
jsoref Oct 29, 2024
1d87e7a
spelling: switched
jsoref Oct 29, 2024
17dcaa1
spelling: system
jsoref Oct 29, 2024
a4729e8
spelling: task
jsoref Oct 31, 2024
ddf87c8
spelling: tells
jsoref Oct 29, 2024
1891e97
spelling: that
jsoref Oct 28, 2024
67a713f
spelling: the
jsoref Oct 28, 2024
32bc977
spelling: this
jsoref Oct 28, 2024
643fa6d
spelling: to
jsoref Oct 29, 2024
eba7cd7
spelling: todo
jsoref Oct 29, 2024
2dfc0af
spelling: transform
jsoref Oct 29, 2024
22b778a
spelling: transformation
jsoref Oct 29, 2024
c0bebed
spelling: transmission
jsoref Oct 29, 2024
9594e61
spelling: troubleshooting
jsoref Oct 30, 2024
5c4c4b1
spelling: unexpected
jsoref Oct 29, 2024
a78e88c
spelling: uniquify
jsoref Oct 29, 2024
fd0271b
spelling: unknown
jsoref Oct 29, 2024
0aa1846
spelling: unmarshalling
jsoref Oct 29, 2024
bec4c76
spelling: unset
jsoref Oct 29, 2024
a716ea4
spelling: unstruct
jsoref Oct 29, 2024
c5fe789
spelling: unstructured
jsoref Oct 29, 2024
d585a32
spelling: update
jsoref Oct 30, 2024
e3e5472
spelling: use
jsoref Oct 28, 2024
2b3e7c8
spelling: validation
jsoref Oct 29, 2024
a725a68
spelling: vm
jsoref Oct 28, 2024
134149e
spelling: waiting
jsoref Oct 29, 2024
49c618d
spelling: webhook
jsoref Oct 30, 2024
88752ad
spelling: width
jsoref Oct 29, 2024
c05a520
spelling: with
jsoref Oct 29, 2024
27afc99
spelling: workload
jsoref Oct 29, 2024
864b1a7
spelling: wrr
jsoref Oct 29, 2024
318ba36
Unindent code block
jsoref Oct 30, 2024
5f3fa01
Avoid `here` links: contributing to projects
jsoref Oct 30, 2024
ec9b132
Avoid `here` links: details about the Absent behavior
jsoref Oct 30, 2024
7b378c1
Avoid `here` links: generated
jsoref Oct 30, 2024
a72dc54
Avoid `here` links: how app engine requests are routed
jsoref Oct 30, 2024
0dc3afe
Avoid `here` links: instructions
jsoref Oct 30, 2024
32af8b1
Avoid `here` links: list of available properties
jsoref Oct 30, 2024
aebc1b3
Avoid `here` links: list of the available pre-defined roles
jsoref Oct 30, 2024
489eba4
Avoid `here` links: register the controller
jsoref Oct 30, 2024
eb6986d
Avoid `here` links: resource reference guidelines
jsoref Oct 30, 2024
ffd9ca2
Avoid `here` links: sample guidelines
jsoref Oct 30, 2024
cb4193a
Avoid `here` links: supported formats
jsoref Oct 30, 2024
c01d6ca
Avoid `here` links: understanding roles
jsoref Oct 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
23 changes: 11 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

We'd love to accept your patches and contributions to this project. We use this
GitHub project as our primary source of truth and the main development
repository for Config Connetor. The source code in this project is also
repository for Config Connector. The source code in this project is also
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

mirrored to internal Google repository for the purposes of releases.

## Contributor License Agreement
Expand Down Expand Up @@ -114,7 +114,7 @@ repo to quickly set up a local dev environment.
./docker-setup.sh
```

1. Exit your current session, then SSH back in to the VM. Then run the
1. Exit your current session, then SSH back into the VM. Then run the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

into changes tend to be controversial. I'm happy to drop any changes and am certainly not attached to these. From my perspective you're "going into the VM" which is why I think it's correct.

following to ensure you have set up sudoless docker correctly:

```shell
Expand Down Expand Up @@ -149,7 +149,7 @@ repo to quickly set up a local dev environment.
```shell
./gcp-setup.sh
```
1. _(Optional)_ Verify that worload identity federation is [setup correctly](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#verify_the_setup).
1. _(Optional)_ Verify that workload identity federation is [setup correctly](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#verify_the_setup).

1. Now that you have everything set up, you can build your own images and then
deploy the Config Connector CRDs and workloads (including controller
Expand Down Expand Up @@ -200,7 +200,7 @@ repo to quickly set up a local dev environment.
The script `gcp-setup.sh` annotates your `default` namespace in the GKE cluster
with a
[project-id](https://cloud.google.com/config-connector/docs/how-to/organizing-resources/project-scoped-resources#annotate_namespace_configuration)
annotation equals to your default GCP project id in gcloud. This enables Config
annotation equal to your default GCP project id in gcloud. This enables Config
Connector to create GCP resources in that default GCP project. We can validate
by creating an Artifact Registry resource through Config Connector.

Expand Down Expand Up @@ -232,8 +232,7 @@ by creating an Artifact Registry resource through Config Connector.

#### Looking for error logs

You can look for error logs by checking the controller logs following the steps
[here](https://cloud.google.com/config-connector/docs/troubleshooting#check-controller-logs).
You can look for error logs by checking the controller logs following the [troubleshooting](https://cloud.google.com/config-connector/docs/troubleshooting#check-controller-logs).

#### Pods fail to pull image
When the cluster is created without providing a service account, a Compute Engine service account is created for the cluster. Users must grant the service account permission to pull images from the project registry.
Expand Down Expand Up @@ -367,14 +366,14 @@ can run it locally on your dev machine with the steps below.
If you are adding a new resource, you need to follow the steps in [NewResourceFromTerraform.md](README.ChangingTerraform.md)
to make code changes, add test data, and run the tests for your resource.

If you are working on a existing resource, test yaml should exist under
If you are working on an existing resource, test yaml should exist under
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling ignores 1 and 2 letter words -- changes in this file were by hand because I read the file...

./pkg/test/resourcefixture/testdata/basic, you can run the test command directly
to make sure the test can still pass. Example command:

```bash
# Export the environment variables needed in the dynamic tests if you haven't done it.
TEST_FOLDER_ID=123456789 go test -v -tags=integration ./pkg/controller/dynamic/ -test.run TestCreateNoChangeUpdateDelete -run-tests cloudschedulerjob -timeout 900s
```
# Export the environment variables needed in the dynamic tests if you haven't done it.
TEST_FOLDER_ID=123456789 go test -v -tags=integration ./pkg/controller/dynamic/ -test.run TestCreateNoChangeUpdateDelete -run-tests cloudschedulerjob -timeout 900s
```
Comment on lines -375 to +376
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here didn't match the rest of the file...

Replace `cloudschedulerjob` with your test target.

### Submit a Pull Request
Expand All @@ -387,5 +386,5 @@ you can first validate the change locally:
make ready-pr
```

You can then commit your change and make a pull request. See more details
[here](https://docs.github.com/en/get-started/quickstart/contributing-to-projects#making-and-pushing-changes).
You can then commit your change and make a pull request. See [GitHub's contributing
to projects: making and pushing changes](https://docs.github.com/en/get-started/quickstart/contributing-to-projects#making-and-pushing-changes).
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ TEST_TARGET ?= mock
e2e-sample-tests:
RUN_E2E=1 E2E_KUBE_TARGET=envtest E2E_GCP_TARGET=${TEST_TARGET} KCC_USE_DIRECT_RECONCILERS="ComputeForwardingRule" \ go test -test.count=1 -timeout 3600s -v ./tests/e2e -run ${SAMPLE_TESTCASE}

# orgnization ID for google.com
# organization ID for google.com
ORG_ID ?= 433637338589
# billing account for ACP
BILLING_ACCOUNT ?= 010E8D-490B6B-088E1C
Expand Down
8 changes: 4 additions & 4 deletions README.ConfigureResourceReferences.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Once it's determined, note down the field name and the referenced GCP resource n

Before you can identify what the resource is based on, you must convert
the Google Cloud resource name or Terraform type name into a
Config Connector kind name. Create a Github question in this repo for help
Config Connector kind name. Create a GitHub question in this repo for help
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a number of brands, I'm not going to tag them all...

if you still can't find the Config Connector kind name after following these steps:

1. If you know the TF type name, you can do project-scoped search in your local
Expand All @@ -80,7 +80,7 @@ if you still can't find the Config Connector kind name after following these ste
[KCC reference doc](https://cloud.google.com/config-connector/docs/reference/overview).

1. If you can't find a KCC kind with the steps above, it's possible that the
referenced resource is not supported in KCC. Create a Github question in this repo
referenced resource is not supported in KCC. Create a GitHub question in this repo
to clarify. If you've determined that the KCC kind is not supported in
KCC, skip ahead to
[Configure reference resource in the service mappings](#configure-reference-in-the-service-mappings).
Expand Down Expand Up @@ -119,10 +119,10 @@ You can find a `Type` field for each argument, and two most common types are

1. If the field is not required, mark it as an ignored field following
[this example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/b746248cd5a9b30669380513de8fdc6b4c43018d/config/servicemappings/cloudbuild.yaml#L204).
1. If the field is required, create a Github question in this repo for
1. If the field is required, create a GitHub question in this repo for
further discussion.

1. If the field isn't a string or a list, create a Github question in this repo
1. If the field isn't a string or a list, create a GitHub question in this repo
for further discussion.

## Configure reference resource in the service mappings
Expand Down
2 changes: 1 addition & 1 deletion apis/bigquery/v1beta1/dataset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type BigQueryDatasetSpec struct {
// afterwards, and does not alter the existing tables.
// The following values are supported:
//
// * 'und:ci': undetermined locale, case insensitive.
// * 'und:ci': undetermined locale, case-insensitive.
// * '': empty string. Default to case-sensitive behavior.
DefaultCollation *string `json:"defaultCollation,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion apis/bigqueryconnection/v1alpha1/connection_reference.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func NewBigQueryConnectionConnectionRef(ctx context.Context, reader client.Reade
}
id.parent = "projects/" + tokens[1] + "/locations/" + tokens[3]

// Validate spec parent and resourceID field if the resource is already reconcilied with a GCP Connection resource.
// Validate spec parent and resourceID field if the resource is already reconciled with a GCP Connection resource.
if tokens[1] != projectID {
return nil, fmt.Errorf("spec.projectRef changed, expect %s, got %s",
tokens[1], projectID)
Expand Down
2 changes: 1 addition & 1 deletion apis/compute/v1beta1/firewallpolicyrule_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ type ComputeFirewallPolicyRuleSpec struct {
/* A match condition that incoming traffic is evaluated against. If it evaluates to true, the corresponding 'action' is enforced. */
Match *FirewallPolicyRuleMatch `json:"match"`

/* Immutable. An integer indicating the priority of a rule in the list. The priority must be a positive value between 0 and 2147483647. Rules are evaluated from highest to lowest priority where 0 is the highest priority and 2147483647 is the lowest prority. */
/* Immutable. An integer indicating the priority of a rule in the list. The priority must be a positive value between 0 and 2147483647. Rules are evaluated from highest to lowest priority where 0 is the highest priority and 2147483647 is the lowest priority. */
Priority int64 `json:"priority"`

// +optional
Expand Down
2 changes: 1 addition & 1 deletion apis/compute/v1beta1/forwardingrule_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ type ComputeForwardingRuleSpec struct {

A Forwarding Rule with protocol L3_DEFAULT can attach with target instance or
backend service with UNSPECIFIED protocol.
A forwarding rule with "L3_DEFAULT" IPProtocal cannot be attached to a backend service with TCP or UDP. Possible values: ["TCP", "UDP", "ESP", "AH", "SCTP", "ICMP", "L3_DEFAULT"]. */
A forwarding rule with "L3_DEFAULT" IPProtocol cannot be attached to a backend service with TCP or UDP. Possible values: ["TCP", "UDP", "ESP", "AH", "SCTP", "ICMP", "L3_DEFAULT"]. */
// +optional
IpProtocol *string `json:"ipProtocol,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion apis/dataflow/v1beta1/flextemplatejob_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ type DataflowFlexTemplateJobObservedState struct {
// Flexible resource scheduling jobs are started with some delay after job
// creation, so start_time is unset before start and is updated when the
// job is started by the Cloud Dataflow service. For other jobs, start_time
// always equals to create_time and is immutable and set by the Cloud Dataflow
// always equals create_time and is immutable and set by the Cloud Dataflow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should either be is always equal to or always equals...

// service.
StartTime *string `json:"startTime,omitempty"`

Expand Down
4 changes: 2 additions & 2 deletions apis/dataflow/v1beta1/types.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/dataform/v1alpha1/repository_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ type DataformRepositoryStatus struct {
// +optional
ObservedGeneration *int64 `json:"observedGeneration,omitempty"`

// A unique specifier for the DataformReposity resource in GCP.
// A unique specifier for the DataformRepository resource in GCP.
// +optional
ExternalRef *string `json:"externalRef,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion apis/dataform/v1beta1/repository_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ type DataformRepositoryStatus struct {
// +optional
ObservedGeneration *int64 `json:"observedGeneration,omitempty"`

// A unique specifier for the DataformReposity resource in GCP.
// A unique specifier for the DataformRepository resource in GCP.
// +optional
ExternalRef *string `json:"externalRef,omitempty"`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ type DiscoveryEngineDataStoreStatus struct {
// +kcc:proto=google.cloud.discoveryengine.v1.DataStore
type DiscoveryEngineDataStoreObservedState struct {
// Output only. The id of the default
// [Schema][google.cloud.discoveryengine.v1.Schema] asscociated to this data
// [Schema][google.cloud.discoveryengine.v1.Schema] associated to this data
// store.
DefaultSchemaID *string `json:"defaultSchemaID,omitempty"`

Expand All @@ -112,7 +112,7 @@ type DiscoveryEngineDataStoreObservedState struct {

// +genclient
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// TODO(user): make sure the pluralizaiton below is correct
// TODO(user): make sure the pluralization below is correct
// +kubebuilder:resource:categories=gcp,shortName=gcpdiscoveryenginedatastore;gcpdiscoveryenginedatastores
// +kubebuilder:subresource:status
// +kubebuilder:metadata:labels="cnrm.cloud.google.com/managed-by-kcc=true";"cnrm.cloud.google.com/system=true"
Expand Down
4 changes: 2 additions & 2 deletions apis/networkconnectivity/v1alpha1/types.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apis/refs/v1beta1/spannerdatabaseref.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ func ResolveSpannerDatabaseRef(ctx context.Context, reader client.Reader, obj cl
})
if err := reader.Get(ctx, key, spannerdatabase); err != nil {
if apierrors.IsNotFound(err) {
return nil, fmt.Errorf("referenced Spanner databse %v not found", key)
return nil, fmt.Errorf("referenced Spanner database %v not found", key)
}
return nil, fmt.Errorf("error reading referenced Spanner databse %v: %w", key, err)
return nil, fmt.Errorf("error reading referenced Spanner database %v: %w", key, err)
}

resourceID, _, err := unstructured.NestedString(spannerdatabase.Object, "spec", "resourceID")
Expand Down
2 changes: 1 addition & 1 deletion apis/sql/v1beta1/instance_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ type InstanceIpConfiguration struct {
// +optional
RequireSsl *bool `json:"requireSsl,omitempty"`

/* Specify how SSL connection should be enforced in DB connections. This field provides more SSL enforcment options compared to requireSsl. To change this field, also set the correspoding value in requireSsl if it has been set. */
/* Specify how SSL connection should be enforced in DB connections. This field provides more SSL enforcement options compared to requireSsl. To change this field, also set the corresponding value in requireSsl if it has been set. */
// +optional
SslMode *string `json:"sslMode,omitempty"`
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,4 @@ insertText: |
forwardInboundCredentials:
idToken: \${58:true}
accessToken: \${59:true}
refereshToken: \${60:true}
refreshToken: \${60:true}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ insertText: |
\${3:oncall-treatment}: \${4:stay-aware}
name: \${5:monitoringalertpolicy-name}
spec:
displayName: \${6:Sample Website Aetwork Connectivity Alert Policy}
displayName: \${6:Sample Website Network Connectivity Alert Policy}
enabled: \${7:true}
notificationChannels:
- name: \${8:monitoringalertpolicy-dep1-networkconnectivity}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ spec:
afterwards, and does not alter the existing tables.
The following values are supported:

* 'und:ci': undetermined locale, case insensitive.
* 'und:ci': undetermined locale, case-insensitive.
* '': empty string. Default to case-sensitive behavior.
type: string
defaultEncryptionConfiguration:
Expand Down
Loading