Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Spelling 9/n #3217

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
4 changes: 2 additions & 2 deletions config/tests/samples/create/harness.go
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ func MaybeSkip(t *testing.T, name string, resources []*unstructured.Unstructured
case schema.GroupKind{Group: "vertexai.cnrm.cloud.google.com", Kind: "VertexAIEndpoint"}:

default:
t.Skipf("gk %v not suppported by mock gcp %v; skipping", gvk.GroupKind(), name)
t.Skipf("gk %v not supported by mock gcp %v; skipping", gvk.GroupKind(), name)
}
}
}
Expand Down Expand Up @@ -928,7 +928,7 @@ func MaybeSkip(t *testing.T, name string, resources []*unstructured.Unstructured

case "projectinorg":
default:
t.Skipf("test %v not suppported by vcr; skipping", name)
t.Skipf("test %v not supported by vcr; skipping", name)
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions crds/bigquery_v1beta1_bigqueryroutine.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ spec:

If absent, the return table type is inferred from definitionBody at query time in each query
that references this routine. If present, then the columns in the evaluated table result will
be cast to match the column types specificed in return table type, at query time.
be cast to match the column types specified in return table type, at query time.
type: string
returnType:
description: |-
Expand All @@ -199,8 +199,8 @@ spec:
that references this routine. If present, then the evaluated result will be cast to
the specified returned type at query time. ~>**NOTE**: Because this field expects a JSON
string, any changes to the string will create a diff, even if the JSON itself hasn't
changed. If the API returns a different value for the same schema, e.g. it switche
d the order of values or replaced STRUCT field type with RECORD field type, we currently
changed. If the API returns a different value for the same schema, e.g. it switched
the order of values or replaced STRUCT field type with RECORD field type, we currently
cannot suppress the recurring diff this causes. As a workaround, we recommend using
the schema as returned by the API.
type: string
Expand Down
4 changes: 2 additions & 2 deletions crds/compute_v1beta1_computeinstance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -826,8 +826,8 @@ spec:
type: string
localSsdRecoveryTimeout:
description: |-
Immutable. Specifies the maximum amount of time a Local Ssd Vm should wait while
recovery of the Local Ssd state is attempted. Its value should be in
Immutable. Specifies the maximum amount of time a Local SSD Vm should wait while
recovery of the Local SSD state is attempted. Its value should be in
between 0 and 168 hours with hour granularity and the default value being 1
hour.
properties:
Expand Down
4 changes: 2 additions & 2 deletions crds/compute_v1beta1_computeinstancetemplate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -839,8 +839,8 @@ spec:
type: string
localSsdRecoveryTimeout:
description: |-
Specifies the maximum amount of time a Local Ssd Vm should wait while
recovery of the Local Ssd state is attempted. Its value should be in
Specifies the maximum amount of time a Local SSD Vm should wait while
recovery of the Local SSD state is attempted. Its value should be in
between 0 and 168 hours with hour granularity and the default value being 1
hour.
items:
Expand Down
4 changes: 2 additions & 2 deletions crds/compute_v1beta1_computenetwork.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ spec:
Immutable. When enabling ula internal ipv6, caller optionally can specify the /48 range
they want from the google defined ULA prefix fd20::/20. The input must be a
valid /48 ULA IPv6 address and must be within the fd20::/20. Operation will
fail if the speficied /48 is already in used by another resource.
If the field is not speficied, then a /48 range will be randomly allocated from fd20::/20 and returned via this field.
fail if the specified /48 is already in used by another resource.
If the field is not specified, then a /48 range will be randomly allocated from fd20::/20 and returned via this field.
type: string
mtu:
description: |-
Expand Down
2 changes: 1 addition & 1 deletion crds/compute_v1beta1_computeurlmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,7 @@ spec:
type: object
retryConditions:
description: |-
Specfies one or more conditions when this retry rule applies. Valid values are:
Specifies one or more conditions when this retry rule applies. Valid values are:

* 5xx: Loadbalancer will attempt a retry if the backend service responds with any 5xx response code,
or if the backend service does not respond at all, example: disconnects, reset, read timeout,
Expand Down
4 changes: 2 additions & 2 deletions crds/dialogflowcx_v1alpha1_dialogflowcxflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ spec:
- audioUri
type: object
telephonyTransferCall:
description: Represents the signal that telles the
description: Represents the signal that tells the
client to transfer the phone call connected to the
agent to a third-party endpoint.
properties:
Expand Down Expand Up @@ -438,7 +438,7 @@ spec:
- audioUri
type: object
telephonyTransferCall:
description: Represents the signal that telles the
description: Represents the signal that tells the
client to transfer the phone call connected to the
agent to a third-party endpoint.
properties:
Expand Down
10 changes: 5 additions & 5 deletions crds/dialogflowcx_v1alpha1_dialogflowcxpage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ spec:
- audioUri
type: object
telephonyTransferCall:
description: Represents the signal that telles the client
description: Represents the signal that tells the client
to transfer the phone call connected to the agent to a
third-party endpoint.
properties:
Expand Down Expand Up @@ -339,7 +339,7 @@ spec:
- audioUri
type: object
telephonyTransferCall:
description: Represents the signal that telles the
description: Represents the signal that tells the
client to transfer the phone call connected to the
agent to a third-party endpoint.
properties:
Expand Down Expand Up @@ -526,7 +526,7 @@ spec:
- audioUri
type: object
telephonyTransferCall:
description: Represents the signal that telles
description: Represents the signal that tells
the client to transfer the phone call connected
to the agent to a third-party endpoint.
properties:
Expand Down Expand Up @@ -733,7 +733,7 @@ spec:
type: object
telephonyTransferCall:
description: Represents the signal that
telles the client to transfer the
tells the client to transfer the
phone call connected to the agent
to a third-party endpoint.
properties:
Expand Down Expand Up @@ -986,7 +986,7 @@ spec:
- audioUri
type: object
telephonyTransferCall:
description: Represents the signal that telles the
description: Represents the signal that tells the
client to transfer the phone call connected to the
agent to a third-party endpoint.
properties:
Expand Down
2 changes: 1 addition & 1 deletion crds/networkservices_v1beta1_networkservicesgrpcroute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ spec:
properties:
numRetries:
description: Specifies the allowed number of retries.
This number must be > 0. If not specpfied, default
This number must be > 0. If not specified, default
to 1.
format: int64
type: integer
Expand Down
2 changes: 1 addition & 1 deletion docs/develop-resources/api-conventions/validations.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ This is the default behavior if using the direct autogenerated code. The code lo

Some existing *v1beta1* resources allow optional `spec.projectRef`, where the project information comes from either the `cnrm.cloud.google.com/project-id` annotation, or the namespace annotation.

When migrating a Terraform-based or DCL-based resource to the direct approach, we want to continue supporitng this behavior for backward compatibility. You can check if the resource uses cnrm.cloud.google.com/project-id` annotation in its Google reference doc.
When migrating a Terraform-based or DCL-based resource to the direct approach, we want to continue supporting this behavior for backward compatibility. You can check if the resource uses cnrm.cloud.google.com/project-id` annotation in its Google reference doc.

## Rule 4: No `anyOf`, `oneOf`, or` allOf`

Expand Down
2 changes: 1 addition & 1 deletion docs/develop-resources/deep-dives/5-releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

* Add `kubebuilder:storageversion` tag to `v1beta1 `API. [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/1b19153411653329177f4ba0991c982f36970707/apis/cloudbuild/v1beta1/workerpool_types.go#L155)

* Run `dev/taks/generate-crds` to patch your resource's CRD with the `v1beta1` version.
* Run `dev/task/generate-crds` to patch your resource's CRD with the `v1beta1` version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, cool!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, actually this is dev/tasks/generate-crds.


## 5.3 Turn on doc auto-generation (direct resource only)

Expand Down
2 changes: 1 addition & 1 deletion experiments/compositions/Design Notes/API Design.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ Q1. Should CRD_T be Namespace-scoped or Cluster-scoped ?
Q2. Choice for CRD_V: Single CRD (Say CompositionValues) for all CRD_T's or Separate CRD for each CRD_T instance ?
> Single CRD => Too generic typing, less scope for access control
> Separate GVR => Better Access controls based on types, Structured API implies better error checking
> We choose to go with Seperate GVR, one per each CRD_T instance.
> We choose to go with Separate GVR, one per each CRD_T instance.
2 changes: 1 addition & 1 deletion experiments/compositions/Design Notes/Applier.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The pod can be as simple as a kubectl cli or a kpt-cli bundled in, or it can be
Since it is not a persistent controller, we cannot implement drift correction.

- Separate pod with kubectl or kpt-cli would take a dependency on an external project and involves security patches for a such image.
- Don't think we need a separate pod for security reasons yet. Separate reconciler per namespace should cover most secutrity concerns.
- Don't think we need a separate pod for security reasons yet. Separate reconciler per namespace should cover most security concerns.

## A persistent pod comms via grpc

Expand Down
4 changes: 2 additions & 2 deletions experiments/compositions/composition/release/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ spec:
description: PlanStatus defines the observed state of Plan
properties:
compositionGeneration:
description: Composition generation last succesfully reconciled
description: Composition generation last successfully reconciled
format: int64
type: integer
compositionUID:
Expand Down Expand Up @@ -851,7 +851,7 @@ spec:
format: int64
type: integer
inputGeneration:
description: Facade's generation last succesfully reconciled
description: Facade's generation last successfully reconciled
format: int64
type: integer
lastPruned:
Expand Down
4 changes: 2 additions & 2 deletions experiments/compositions/composition/release/manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ spec:
description: PlanStatus defines the observed state of Plan
properties:
compositionGeneration:
description: Composition generation last succesfully reconciled
description: Composition generation last successfully reconciled
format: int64
type: integer
compositionUID:
Expand Down Expand Up @@ -864,7 +864,7 @@ spec:
format: int64
type: integer
inputGeneration:
description: Facade's generation last succesfully reconciled
description: Facade's generation last successfully reconciled
format: int64
type: integer
lastPruned:
Expand Down
2 changes: 1 addition & 1 deletion experiments/compositions/samples/AppTeam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
EOF
```

Verify the relevant resources are created succesfully
Verify the relevant resources are created successfully

```
./get_appteam.sh ${TEAM_NAME}
Expand Down
2 changes: 1 addition & 1 deletion experiments/compositions/samples/CloudSQL/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
EOF
```

Verify the relevant resources are created succesfully by running:
Verify the relevant resources are created successfully by running:

```
./get_cloudsql.sh ${NAMESPACE}
Expand Down
4 changes: 2 additions & 2 deletions mockgcp/mockkms/cryptokeyversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,10 @@ func (r *kmsServer) DestroyCryptoKeyVersion(ctx context.Context, req *pb.Destroy
parent = cryptoKey
}

destroyScheuledDuration := parent.GetDestroyScheduledDuration().AsDuration()
destroyScheduledDuration := parent.GetDestroyScheduledDuration().AsDuration()

obj.State = pb.CryptoKeyVersion_DESTROY_SCHEDULED
obj.DestroyTime = timestamppb.New(now.Add(destroyScheuledDuration))
obj.DestroyTime = timestamppb.New(now.Add(destroyScheduledDuration))

if err := r.storage.Update(ctx, fqn, obj); err != nil {
return nil, err
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ func (r *Reconciler) handleConfigConnectorLifecycle() declarative.ObjectTransfor
if err := r.client.Update(ctx, cc); err != nil {
return fmt.Errorf("error adding %v finalizer in ConfigConnector object %v: %w", k8s.OperatorFinalizer, cc.GetName(), err)
}
// Create the cnrm-systm namespace first; this is done to prevent the creation of components from failing due to the cnrm-system namespace not existing yet.
// Create the cnrm-system namespace first; this is done to prevent the creation of components from failing due to the cnrm-system namespace not existing yet.
if err := createCNRMSystemNamespace(ctx, r.client, m); err != nil {
return fmt.Errorf("error creating %v namespace: %w", k8s.CNRMSystemNamespace, err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/gcpclient/resolve_apiserver_dependencies_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func convertSensitiveFieldsToValue(t *testing.T, resources []*unstructured.Unstr
field.Value = &value
var newValue map[string]interface{}
if err := util.Marshal(field, &newValue); err != nil {
t.Fatalf("error marshalling SenesitiveField '%v' to a object map: %v", field, err)
t.Fatalf("error marshalling SensitiveField '%v' to a object map: %v", field, err)
}
mapValue := obj.(map[string]interface{})
for k := range mapValue {
Expand Down
4 changes: 2 additions & 2 deletions pkg/cli/stream/yamlstream.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

var (
yamlSeperator = []byte("---\n")
yamlSeparator = []byte("---\n")
// YAML streams are terminated with "..." which signifies the end of transmission: https://yaml.org/spec/1.2/spec.html
yamlTransmissionTerminator = []byte("...")
)
Expand Down Expand Up @@ -76,7 +76,7 @@ func (y *YAMLStream) Next(ctx context.Context) ([]byte, *unstructured.Unstructur
y.nextErr = nil
return nil, nil, err
}
bytes = append(yamlSeperator, bytes...)
bytes = append(yamlSeparator, bytes...)
y.fillNext(ctx)
y.returnedAtLeastOneNonErrorResult = true
return bytes, unstructured, nil
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/controller/direct/compute/forwardingrule/mapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func ComputeForwardingRuleSpec_IpAddress_FromProto(mapCtx *direct.MapContext, in
return out
}

func ComputeForwardingRuleSpec_BackendSeriviceRef_FromProto(mapCtx *direct.MapContext, in string) *refs.ComputeBackendServiceRef {
func ComputeForwardingRuleSpec_BackendServiceRef_FromProto(mapCtx *direct.MapContext, in string) *refs.ComputeBackendServiceRef {
if in == "" {
return nil
}
Expand All @@ -61,7 +61,7 @@ func ComputeForwardingRuleSpec_BackendSeriviceRef_FromProto(mapCtx *direct.MapCo
}
}

func ComputeForwardingRuleSpec_BackendSeriviceRef_ToProto(mapCtx *direct.MapContext, in *refs.ComputeBackendServiceRef) *string {
func ComputeForwardingRuleSpec_BackendServiceRef_ToProto(mapCtx *direct.MapContext, in *refs.ComputeBackendServiceRef) *string {
if in == nil {
return nil
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/direct/resourcemanager/tagkey_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ func (a *tagKeyAdapter) Update(ctx context.Context, updateOp *directbase.UpdateO
if _, err := op.Wait(ctx); err != nil {
return fmt.Errorf("tagKey update failed: %w", err)
}
// TODO: Do we need to check that the operation succeeeded?
// TODO: Do we need to check that the operation succeeded?
}

// TODO: Return updated object status
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/iam/iamclient/iamclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const (
IAMGroup = "iam.cnrm.cloud.google.com"
IAMVersion = "v1beta1"

SerivceIdentityKind = "ServiceIdentity"
ServiceIdentityKind = "ServiceIdentity"
ServiceUsageGroup = "serviceusage.cnrm.cloud.google.com"
ServiceUsageVersion = "v1beta1"
)
Expand Down Expand Up @@ -83,7 +83,7 @@ var (
ServiceIdentityGVK = schema.GroupVersionKind{
Group: ServiceUsageGroup,
Version: ServiceUsageVersion,
Kind: SerivceIdentityKind,
Kind: ServiceIdentityKind,
}
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/dcl/conversion/converter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@ func TestConverter_DCLObjectToKRMObject(t *testing.T) {
// Read-only sensitive and reference fields are
// surfaced onto the spec if they're part of
// objects within collections (maps, arrays)
// and simply srufaced as strings rather than
// and simply surfaced as strings rather than
// sensitive or reference structs.
"readOnlySensitiveField": "sensitiveVal",
"readOnlyReferenceField": "referenceVal",
Expand Down Expand Up @@ -1487,7 +1487,7 @@ func TestConverter_DCLObjectToKRMObject(t *testing.T) {
// Read-only sensitive and reference fields are
// surfaced onto the spec if they're part of
// objects within collections (maps, arrays)
// and simply srufaced as strings rather than
// and simply surfaced as strings rather than
// sensitive or reference structs.
"readOnlySensitiveField": "sensitiveVal",
"readOnlyReferenceField": "referenceVal",
Expand Down
2 changes: 1 addition & 1 deletion pkg/dcl/kcclite/conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func convertConfig(config map[string]interface{}, path []string, schema *openapi
return config, nil
}
if schema.Type != "object" {
return nil, fmt.Errorf("expect the schame type to be 'object', but got %v", schema.Type)
return nil, fmt.Errorf("expect the schema type to be 'object', but got %v", schema.Type)
}
for f, s := range schema.Properties {
if dclextension.IsReferenceField(s) {
Expand Down
Loading
Loading