-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Spelling 10/n #3218
[CHORE] Spelling 10/n #3218
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@@ -24,7 +24,7 @@ spec: | |||
external: projects/${projectId} | |||
serviceRef: | |||
external: monitoringservice-${uniqueId} | |||
displayName: "updae request - a window based metric sum filter" | |||
displayName: "update request - a window based metric sum filter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break this test. To fix that, could you run hack/compare-mock fixtures/windowbasedmetricsumfilter
? Or just drop this change. Ditto to the pkg/test/resourcefixture/testdata/basic/monitoring/v1beta1/monitoringservicelevelobjective/windowbasedmetricsumfilter/_generated_object_windowbasedmetricsumfilter.golden.yaml file above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 92d726e does what you want
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
The first error appears to be:
"""
... // 565 identical lines
{
"role": "OWNER",
- "userByEmail": "[email protected]"
+ "specialGroup": "projectOwners"
},
{
"role": "OWNER",
- "specialGroup": "projectOwners"
+ "userByEmail": "[email protected]"
}
],
... // 373 identical lines
"""
) Which doesn't seem like something I'm doing... |
yeah. The presubmit was broken. Could you rebase from master head? It should pass now |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
966fc94
into
GoogleCloudPlatform:master
Change description
Subset of #3062
Tests you have done
make ready-pr
to ensure this PR is ready for review.