Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Spelling 10/n #3218

Merged
merged 18 commits into from
Nov 21, 2024
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 20, 2024

Change description

Subset of #3062

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref mentioned this pull request Nov 20, 2024
14 tasks
@@ -24,7 +24,7 @@ spec:
external: projects/${projectId}
serviceRef:
external: monitoringservice-${uniqueId}
displayName: "updae request - a window based metric sum filter"
displayName: "update request - a window based metric sum filter"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this test. To fix that, could you run hack/compare-mock fixtures/windowbasedmetricsumfilter ? Or just drop this change. Ditto to the pkg/test/resourcefixture/testdata/basic/monitoring/v1beta1/monitoringservicelevelobjective/windowbasedmetricsumfilter/_generated_object_windowbasedmetricsumfilter.golden.yaml file above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 92d726e does what you want

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Nov 20, 2024

The first error appears to be:

2024-11-20T20:36:32.1050618Z     utils.go:110: FAIL: unexpected diff in /home/runner/work/k8s-config-connector/k8s-config-connector/pkg/test/resourcefixture/testdata/basic/bigquery/v1beta1/bigquerydataset/fullybigquerydataset/_http.log:   (
    """
  	... // 565 identical lines
  	    {
  	      "role": "OWNER",
- 	      "userByEmail": "[email protected]"
+ 	      "specialGroup": "projectOwners"
  	    },
  	    {
  	      "role": "OWNER",
- 	      "specialGroup": "projectOwners"
+ 	      "userByEmail": "[email protected]"
  	    }
  	  ],
  	... // 373 identical lines
  	"""
  )

Which doesn't seem like something I'm doing...

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 20, 2024

The first error appears to be:

2024-11-20T20:36:32.1050618Z     utils.go:110: FAIL: unexpected diff in /home/runner/work/k8s-config-connector/k8s-config-connector/pkg/test/resourcefixture/testdata/basic/bigquery/v1beta1/bigquerydataset/fullybigquerydataset/_http.log:   (
    """
  	... // 565 identical lines
  	    {
  	      "role": "OWNER",
- 	      "userByEmail": "[email protected]"
+ 	      "specialGroup": "projectOwners"
  	    },
  	    {
  	      "role": "OWNER",
- 	      "specialGroup": "projectOwners"
+ 	      "userByEmail": "[email protected]"
  	    }
  	  ],
  	... // 373 identical lines
  	"""
  )

Which doesn't seem like something I'm doing...

yeah. The presubmit was broken. Could you rebase from master head? It should pass now

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 20, 2024

/lgtm

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 20, 2024

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 966fc94 into GoogleCloudPlatform:master Nov 21, 2024
24 of 25 checks passed
@jsoref jsoref deleted the spelling-10 branch November 21, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants