Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve propose-tag script #3573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xiaoweim
Copy link
Collaborator

@xiaoweim xiaoweim commented Jan 30, 2025

Change description

Integrate all the necessary steps in propose release candidate to the propose-tag script.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@xiaoweim
Copy link
Collaborator Author

/assign @yuwenma

@xiaoweim
Copy link
Collaborator Author

/assign @justinsb

dev/tasks/propose-tag Outdated Show resolved Hide resolved
@xiaoweim xiaoweim force-pushed the improve_propose_tag branch 2 times, most recently from cd87539 to 74dac01 Compare February 1, 2025 00:07
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

one nit

dev/tasks/propose-tag Outdated Show resolved Hide resolved
dev/tasks/propose-tag Outdated Show resolved Hide resolved
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaoweim xiaoweim force-pushed the improve_propose_tag branch 2 times, most recently from 9ce11f5 to cee6f48 Compare February 4, 2025 19:08
@xiaoweim xiaoweim force-pushed the improve_propose_tag branch from cee6f48 to 17e6a86 Compare February 4, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants