Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cert-manager to 1.5.0 #372

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

gkcalat
Copy link
Contributor

@gkcalat gkcalat commented Jul 12, 2022

Changes:

  • replaced cert-manager.io/v1alpha2 API due to deprecation
  • renamed folder to reflect a proper version
  • adjusted .krmignore

@gkcalat
Copy link
Contributor Author

gkcalat commented Jul 12, 2022

/assign zijianjoy

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you so much Ablai!

NIT: We can mention corresponding bug in PR for reference in the future. For example: #365

@google-oss-prow google-oss-prow bot added the lgtm label Jul 12, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkcalat, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0bed487 into GoogleCloudPlatform:master Jul 12, 2022
@gkcalat gkcalat mentioned this pull request Aug 4, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants