Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cert-manager to 1.10.2. Closes #405. #409

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Upgrade cert-manager to 1.10.2. Closes #405. #409

merged 2 commits into from
Mar 20, 2023

Conversation

gkcalat
Copy link
Contributor

@gkcalat gkcalat commented Mar 12, 2023 •
edited
Loading

Previous upgrade: cert-manger 1.5.0

  • Updated the upstream version
  • Changed the folder name
  • Updated .krmignore
  • Tested on GKE 1.23

Full testing on GKE 1.24 or 1.25 will be done once all components will be upgraded.

I chose 1.10.2 over 1.10.1 as the latest patch included vulnerability fixes and a significant performance boost.

@gkcalat gkcalat mentioned this pull request Mar 12, 2023
Merged
2 tasks
zijianjoy
zijianjoy reviewed Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@zijianjoy zijianjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but do we want to remove version number cert-manager-1-10 from the folder name? In this case, we just need to pull from upstream and rely on it for cert manager version.

@gkcalat
Copy link
Contributor Author

gkcalat commented Mar 15, 2023

It looks good to me, but do we want to remove version number cert-manager-1-10 from the folder name? In this case, we just need to pull from upstream and rely on it for cert manager version.

Thank you! Updated.

@gkcalat gkcalat requested a review from zijianjoy March 17, 2023 17:41
zijianjoy
zijianjoy approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@zijianjoy zijianjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ablai for the contribution!

kubeflow/common/cert-manager/kustomization.yaml Show resolved Hide resolved
@gkcalat gkcalat merged commit dc5beb4 into GoogleCloudPlatform:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijianjoy zijianjoy zijianjoy approved these changes

Assignees

@zijianjoy zijianjoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkcalat @zijianjoy