Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.0 #14

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Release v1.8.0 #14

merged 2 commits into from
Nov 17, 2023

Conversation

chensun
Copy link
Member

@chensun chensun commented Nov 7, 2023

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseURL should be equal to different values in different branches:

  • main: https://googlecloudplatform.github.io/kubeflow-gke-docs/dev
  • v1.7-release: https://googlecloudplatform.github.io/kubeflow-gke-docs/v1.7
  • (new) v1.8-release: https://googlecloudplatform.github.io/kubeflow-gke-docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[params]:

  • version_menu
    • main: dev
    • v1.7-release: v1.7
    • (new) v1.8-release: v1.8 (latest)
  • archived_version
    • main: false
    • v1.7-release: true
    • (new) v1.8-release: false
  • version
    • main: dev
    • v1.7-release: v1.7
    • (new) v1.8-release: v1.8
  • version_url_prefix
    • main: /dev
    • v1.7-release: ""
    • (new) v1.8-release: ""
  • github_branch
    • main: main
    • v1.7-release: v1.7-release
    • (new) v1.8-release: v1.8-release

There are comments starting with <<<<<<<<<<<<<<<<<.

Sorry, the release process is very clumsy. Feel free to update the instructions and suggest improvements.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: #3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Given this is merging into main, I'll keep it as-is, i.e. with value dev. After I cut v1.8-release branch. I will update it within the branch.

config.toml Outdated
githubbranch = "v1.8-release"
url = "https://googlecloudplatform.github.io/kubeflow-gke-docs/docs"
[[params.versions]]
version = "v1.7"
githubbranch = "v1.7-release"
url = "https://googlecloudplatform.github.io/kubeflow-gke-docs/docs"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url = "https://googlecloudplatform.github.io/kubeflow-gke-docs/v1.7/docs"

Copy link
Member Author

@chensun chensun Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


### Changes:

- 🔼 Upgraded upstream `Manifests` to `v1.8.0`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it the only change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's only meaningful change worth highligh in release note (there're two more merged changed which are considered chore)

Copy link
Collaborator

@gkcalat gkcalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chensun

@chensun chensun requested a review from gkcalat November 16, 2023 07:55
@chensun chensun merged commit 8136421 into GoogleCloudPlatform:main Nov 17, 2023
1 check passed
@chensun chensun deleted the kf18 branch November 17, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants