Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused k8s file #951

Closed
wants to merge 1 commit into from
Closed

Remove unused k8s file #951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions gke-scheduled-autoscaler/k8s/deployment-example.yaml
View file
Open in desktop
Copy link
Collaborator

@NimJay NimJay Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! (You pointed out that gke-scheduled-autoscaler/k8s/hpa-example.yaml is in use.)

Issue: Also, it looks like this deployment-example.yaml is also used by that tutorial.

kubectl apply -f ./k8s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch. I had searched for the file name without realizing that command applied everything at once. Seems like we won't be able to simply remove it after all.

This file was deleted.

Loading