Add Network Firewall Policy Policy Packet Mirroring Rule resource

[mihhalj]

As part of the work to launch Network Security Integrations (NSI) (b/352252592) we introduce a new resource to allow users to configure Network Firewall Policy Packet Mirroring rules.

In this PR we add Terraform support for the new resource type.

`google_compute_network_firewall_policy_packet_mirroring_rule` (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

First pass looks good, just some minor comments, and will run tests

[roaks3]

Would you mind rebasing and then removing the fields that are no longer under async supported here?

[mihhalj]

done

[roaks3]

This should be something with a hyphen, like "fw-network" (we have special handling that relies on the hyphen being present)

[mihhalj]

done

[roaks3]

Nit: spacing, especially since this will show up on the docs page

[mihhalj]

fixed

[roaks3]

Could you omit the optional fields from either the _basic or _update config, to confirm they can be properly omitted?

[mihhalj]

done - I removed description, rule_name, disabled which are optional

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 293 insertions(+))
google-beta provider: Diff ( 6 files changed, 1611 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 266 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_network_firewall_policy_packet_mirroring_rule (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy_packet_mirroring_rule" "primary" {
  match {
    dest_ip_ranges = # value needed
    layer4_configs {
      ports = # value needed
    }
  }
  tls_inspect = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1099
Passed tests: 1022
Skipped tests: 75
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample
• TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test