Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SchedulingConfig.spot to TPU v2 VM #13211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kentwhf
Copy link

@kentwhf kentwhf commented Feb 27, 2025

Support spot boolean field for TPU VMs in Terraform. This should closely mirror the gcloud --spot flag and can reuse the same external field description and wording.

tpuv2: added `spot` field to `google_tpu_v2_vm` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 27, 2025
@kentwhf kentwhf marked this pull request as ready for review February 27, 2025 21:27
@github-actions github-actions bot requested a review from melinath February 27, 2025 21:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants