Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify the columns in the backfill procedures, makes sure the script… #254

Merged

Conversation

kingman
Copy link
Collaborator

@kingman kingman commented Nov 25, 2024

…s are executable with a previous created feature table

Description

When the backfill scripts changes and the user try to re-run a backfill with an existing feature table, they will get Query error: Inserted row has wrong column count error. this also ensures that the columns are mapped correctly

How has this been tested?

in the integration test environment

Please explain how you have tested the new changes.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

…s are executable with a previous created feature table
Copy link
Collaborator

@chmstimoteo chmstimoteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chmstimoteo chmstimoteo merged commit 92b585a into GoogleCloudPlatform:main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backfill scripts causes Query error: Inserted row has wrong column count
2 participants