Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update billing-integration.md serviceName endpoint description #617

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update billing-integration.md serviceName endpoint description #617

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7422f4e
Update billing-integration.md serviceName endpoint description
linhlam-kc Aug 4, 2023
5b9604d
Update billing-integration.md - fix typos
linhlam-kc Aug 4, 2023
4f9fc28
Update billing-integration.md - update service name description line #19
linhlam-kc Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions docs/billing-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Kubernetes apps that bill a Google Cloud customer's account must report usage to

Usage reporting requires the following information:
* Predefined usage metrics. These metrics (such as `requests` or `instance_time`) are defined when choosing a pricing model. Usage for these metrics must be reported from your deployed application.
* A service name. This name identifies your product and will look like `my-application.mp-my-company.appspot.com`. It will be provided by Google during onboarding.
* A service name. This name identifies your product and will look like `my-application.endpoints.projectId.cloud.goog`. It will be provided by Google as your product ID during onboarding. You can also find your product ID on the producer portal. (If your published product on GCP Marketplace is using the service name in this previous format `my-application.mp-my-company.appspot.com`, you can continue using the current serviceName)
* A GCP service account key to use for reporting. This will be provided to your application at deployment time.
* A consumer ID. This will be provided to your application at deployment time.

Expand Down Expand Up @@ -155,9 +155,14 @@ data:
- name: servicecontrol
servicecontrol:
identity: gcp
# The service name is unique to your application and will be
# provided during onboarding.
serviceName: my-application.mp-my-company.appspot.com
# The service name is unique to your application. You can find
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update working on line 19 too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean line 159 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibbleyg I have updated line 19 in the latest commit. Please check again and let me know if I need to update anything. Thanks !

# and use your product ID from the GCP Producer Portal. The following
# example uses the product ID as the serviceName.
#
# NOTE: If your published product is using the service name in this previous format
# "my-application.mp-my-company.appspot.com", you can continue
# using the current serviceName.
serviceName: my-application.endpoints.projectId.cloud.goog
consumerId: $AGENT_CONSUMER_ID # From the reporting secret.

# The sources section lists metric data sources run by the agent
Expand Down