-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding uptime-checks-workload.v1.json #699
base: master
Are you sure you want to change the base?
adding uptime-checks-workload.v1.json #699
Conversation
"displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure" | ||
"documentation": {}, | ||
"userLabels": { | ||
"workload_name": "${WORKLOAD_NAME}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to match all the environment variables set from the Workload Details Observability tab
workload_type = gke_deployment
location = ${LOCATION}
project_id = ${PROJECT_ID}
namespace = ${NAMESPACE}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if i'm missing something, where are these user labels getting populated in the workload details tab?
@@ -0,0 +1,37 @@ | |||
{ | |||
"displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now but note we can technically support uptime checks for ingress via URL, so we may want to consider passing in the "Load Balancer" part of the display name
"perSeriesAligner": "ALIGN_NEXT_OLDER", | ||
"crossSeriesReducer": "REDUCE_COUNT_FALSE", | ||
"groupByFields": [ | ||
"resource.label.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current alert policy lists these out, but if we want to support ingress + load balancer through the same policy template then I think this is fine
"cluster": "${CLUSTER_NAME}", | ||
"uptime_check_id": "${UPTIME_CHECK_ID}", | ||
}, | ||
"conditions": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing conditions.displayName -> "Failure of ${alertPolicy.displayName}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how we'll populate the alert policy display name, i think it would make sense to put the uptime check name here?
…emplates.yaml
No description provided.