Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding uptime-checks-workload.v1.json #699

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nikitajainn-google
Copy link

No description provided.

alerts/google-gke/uptime-checks.v1.json Outdated Show resolved Hide resolved
alerts/google-gke/uptime-checks.v1.json Outdated Show resolved Hide resolved
@nikitajainn-google nikitajainn-google changed the title adding uptime-checks.v1.json adding uptime-checks-workload.v1.json Feb 14, 2024
"displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure"
"documentation": {},
"userLabels": {
"workload_name": "${WORKLOAD_NAME}",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to match all the environment variables set from the Workload Details Observability tab

workload_type = gke_deployment
location = ${LOCATION}
project_id = ${PROJECT_ID}
namespace = ${NAMESPACE}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if i'm missing something, where are these user labels getting populated in the workload details tab?

@@ -0,0 +1,37 @@
{
"displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now but note we can technically support uptime checks for ingress via URL, so we may want to consider passing in the "Load Balancer" part of the display name

"perSeriesAligner": "ALIGN_NEXT_OLDER",
"crossSeriesReducer": "REDUCE_COUNT_FALSE",
"groupByFields": [
"resource.label.*"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current alert policy lists these out, but if we want to support ingress + load balancer through the same policy template then I think this is fine

"cluster": "${CLUSTER_NAME}",
"uptime_check_id": "${UPTIME_CHECK_ID}",
},
"conditions": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing conditions.displayName -> "Failure of ${alertPolicy.displayName}"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how we'll populate the alert policy display name, i think it would make sense to put the uptime check name here?

…emplates.yaml
@nikitajainn-google nikitajainn-google marked this pull request as draft February 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants