Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change featuregate name #197

Merged
merged 2 commits into from
Jan 19, 2024
Merged

change featuregate name #197

merged 2 commits into from
Jan 19, 2024

Conversation

braydonk
Copy link
Contributor

The featuregate name changed in the googlemanagedprometheus exporter library in opentelemetry-operations-go library. This PR changes the featuregate name to match.

I would add a test for this, but I am trying to reduce how much we deviate from upstream to make it easier to migrate for future changes we need to move forward in our fork.

Copy link
Member

@jefferbrecht jefferbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test failure is almost certainly unrelated to this change, it is weird though because Quentin's PR from the other day was fine. Maybe it's just flaky, I'll try re-running it.

@braydonk
Copy link
Contributor Author

We've decided to merge despite the borked kokoro issues which are occurring due to an issue with running golangci-lint in the new golang docker container.

@jefferbrecht jefferbrecht merged commit 3845736 into master Jan 19, 2024
7 checks passed
@braydonk braydonk deleted the gate_name_change branch January 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants