-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update otel collector to v0.106.1. #224
Merged
franciscovalentecastro
merged 8 commits into
master
from
fcovalente-otel-update-v0.106.1
Aug 12, 2024
Merged
Update otel collector to v0.106.1. #224
franciscovalentecastro
merged 8 commits into
master
from
fcovalente-otel-update-v0.106.1
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscovalentecastro
requested review from
a team and
avilevy18
and removed request for
a team
August 8, 2024 18:08
franciscovalentecastro
changed the title
[Draft] Update otel collector to v0.106.1.
Update otel collector to v0.106.1.
Aug 8, 2024
avilevy18
reviewed
Aug 8, 2024
…finintion (see opentelemetry-collector PR #10436 ).
avilevy18
approved these changes
Aug 12, 2024
braydonk
approved these changes
Aug 12, 2024
franciscovalentecastro
added a commit
that referenced
this pull request
Aug 12, 2024
This reverts commit 169f407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the opentelemetry-collector dependency to
v0.106.1
. Some changes were required after the update. Some details :CreateSettings
andNewCreateNopSettings
were deprecate in favour ofSettings
andNewNopSettings
:golang.org/x/tools/cmd/goimports
instead of onlygolang.org/x/tools
which wasn't providing the module correctly.UnmarshalConfig
is deprecated. UsingUnmarshal
instead :ConfigProvider
s are set anymore. Supplied manuallyfile
,env
andyaml
config providers which seem are the only necessary for theopentelemetry-operations-collector
:NewCommand
should supply any default providers/converters open-telemetry/opentelemetry-collector#10290