-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MS SQL Server Errorlog Support #1687
base: master
Are you sure you want to change the base?
Add MS SQL Server Errorlog Support #1687
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
} | ||
|
||
func (p LoggingProcessorMssqlLog) Components(ctx context.Context, tag string, uid string) []fluentbit.Component { | ||
c := confgenerator.LoggingProcessorParseRegex{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the Regex, we need the parser shared section that tells fluentbit how to parse the timestamp. the one below is copied from saphana so it's not the right field/format.
ParserShared: confgenerator.ParserShared{
TimeKey: "time",
TimeFormat: "%Y-%m-%d %H:%M:%S.%L",
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR calls this out:
// Not sending the log timestamp "logtime" from above in as the Time_Key as there will be time zone issues.
// MS SQL Server writes logs in server time, not a standard time zone such as UTC
I can add these comments in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll add the comment and see how the ops-agent team would like to handle it.
integration_test/third_party_apps_test/applications/mssql/enable
Outdated
Show resolved
Hide resolved
Just giving an update from our side chats: this is blocked on not having UTF-16 support in Fluent Bit, and that support has not yet been prioritized. We'll give another update here once that changes. |
Description
This PR adds support for Microsoft SQL Server error logs.
Related issue
Code for this PR references this PR from 03/2022
How has this been tested?
Checklist: