Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile support for Ubuntu 24.10 Oracular + Updated Instructions for running ops agent integration tests against the new distro #1820

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Dockerfile support for Ubuntu 24.10 Oracular + Updated Instructions for running ops agent integration tests against the new distro #1820

merged 6 commits into from
Nov 1, 2024

Conversation

XuechunHou
Copy link
Contributor

@XuechunHou XuechunHou commented Oct 31, 2024 •
edited
Loading

Description

  1. Dockerfile support for Ubuntu 24.10 Oracular
  2. Updated instructions for running ops_agent_test integration tests against the new distro.

Related issue

b/375011241

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@XuechunHou XuechunHou changed the title Xuechun hou patch 1 Dockerfile support for Ubuntu 24.10 Oracular + Updated Instructions to adding new distro support in Ops Agent Oct 31, 2024
@XuechunHou XuechunHou changed the title Dockerfile support for Ubuntu 24.10 Oracular + Updated Instructions to adding new distro support in Ops Agent Dockerfile support for Ubuntu 24.10 Oracular + Updated Instructions for running ops agent integration tests against the new distro Oct 31, 2024
franciscovalentecastro
franciscovalentecastro reviewed Oct 31, 2024
View reviewed changes
Dockerfile
RUN set -x; apt-get update && \
DEBIAN_FRONTEND=noninteractive apt-get -y install git systemd \
autoconf libtool libcurl4-openssl-dev libltdl-dev libssl-dev libyajl-dev \
build-essential cmake bison flex file systemd-dev debhelper libsystemd-dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to make note that debhelper and system-dev had to be added here to make the build work.

franciscovalentecastro
franciscovalentecastro approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XuechunHou XuechunHou merged commit dda6278 into master Nov 1, 2024
55 of 60 checks passed
@XuechunHou XuechunHou deleted the XuechunHou-patch-1 branch November 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

@jefferbrecht jefferbrecht Awaiting requested review from jefferbrecht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuechunHou @franciscovalentecastro