feat: support all 'spanner.*' options in pg_settings #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-writes the pg_settings common table expression to use an array of jsonb instead of a list of UNION ALL statements. This circumvents the limitation that a query cannot contain more than 60 UNION ALLs, which means that we can put a larger value for the limitation on the number of settings included in the CTE. We still restrict the number of elements in the CTE to prevent the query text from becoming too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-writes the pg_settings common table expression to use an array of jsonb instead of a list of UNION ALL statements. This circumvents the limitation that a query cannot contain more than 60 UNION ALLs, which means that we can put a larger value for the limitation on the number of settings included in the CTE. We still restrict the number of elements in the CTE to prevent the query text from becoming too long.