[Draft] TPC-C Hibernate runner #2544
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
reviewed
Nov 21, 2024
benchmarks/tpcc/src/main/java/com/google/cloud/pgadapter/tpcc/HibernateBenchmarkRunner.java
Show resolved
Hide resolved
benchmarks/tpcc/src/main/java/com/google/cloud/pgadapter/tpcc/HibernateBenchmarkRunner.java
Outdated
Show resolved
Hide resolved
benchmarks/tpcc/src/main/java/com/google/cloud/pgadapter/tpcc/entities/Customer.java
Outdated
Show resolved
Hide resolved
benchmarks/tpcc/src/main/java/com/google/cloud/pgadapter/tpcc/entities/District.java
Outdated
Show resolved
Hide resolved
benchmarks/tpcc/src/main/java/com/google/cloud/pgadapter/tpcc/HibernateBenchmarkRunner.java
Show resolved
Hide resolved
benchmarks/tpcc/src/main/java/com/google/cloud/pgadapter/tpcc/HibernateBenchmarkRunner.java
Outdated
Show resolved
Hide resolved
hengfengli
reviewed
Dec 10, 2024
There was a problem hiding this comment.
LGTM. Please also add instructions how to run the Hibernate runner in https://github.com/GoogleCloudPlatform/pgadapter/tree/postgresql-dialect/benchmarks/tpcc.
| static final String ROUNDTRIP_LATENCY_DESCRIPTION = | ||
| "Latency when the benchmark runner sends out a query and gets a response"; | ||
|
|
||
| static final String TPCC_NEWORDER_LATENCY = "spanner/benchmarker/tpcc_neworder_latencies"; |
There was a problem hiding this comment.
Have we considered to add only one metric, e.g., spanner/benchmarker/tpcc_transaction_latencies and use a field in the Attributes to indicate the transaction type?
| conn.setReadOnly(false); | ||
| conn.createStatement().execute("set auto_batch_dml=true"); | ||
| conn.createStatement().execute("set auto_batch_dml_update_count_verification=false"); | ||
| //conn.createStatement().execute("set transaction_tag='" + transactionTag + "'"); |
| import org.hibernate.Session; | ||
| import org.hibernate.SessionFactory; | ||
|
|
||
| public class SessionHelper { |
There was a problem hiding this comment.
Should we be more specific to Hibernate session, e.g., HibernateSessionHelper?
| pgadapter.num-channels=32 | ||
|
|
||
| # Set this if you want the in-process PGAdapter instance to use a specific service account | ||
| # credentials file. | ||
| # Leave unset if the application should use the APPLICATION_DEFAULT_CREDENTIALS. | ||
| pgadapter.credentials=/path/to/credentials.json | ||
| pgadapter.credentials=/Users/rayudualp/Downloads/span-cloud-testing-5084c5e7353d.json |
There was a problem hiding this comment.
We probably should not update this file except adding the hibernate settings below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction metrics , Hibernaterunner(v1) implementation