Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and deprecated Go module #46

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Upgrade dependencies and deprecated Go module #46

merged 2 commits into from
Apr 4, 2024

Conversation

mfridman
Copy link
Contributor

@mfridman mfridman commented Apr 4, 2024

This PR does a few things, but the ultimate goal is to deprecate the older Go module:

go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead.
  1. Replace types for their equivalent google.golang.org/protobuf counterparts
  2. Update go.mod deps and tidy
  3. Re-generate the examples in ./protos directory with the latest protoc version (26.1) and the latest protoc-gen-go version (v1.33.0).
  4. Update Makefile
  5. Bumps go version to 1.16 (from 1.15), to use io.ReadAll (ioutil was deprecated).
  6. Bumps GitHub actions to the latest major workflows

cc @mescanne wdyt about also tagging a semver release like v1.1.0?

@mescanne
Copy link
Collaborator

mescanne commented Apr 4, 2024

Looks good to me. New semver release also makes sense.

@mfridman
Copy link
Contributor Author

mfridman commented Apr 4, 2024

Awesome, thanks for taking a look. I'm happy to help address outstanding issues or make incremental improvements if you're up for a few reviews.

Also, thank you for publishing a new release 🙌 .

@mescanne
Copy link
Collaborator

mescanne commented Apr 4, 2024

I'm currently really maxed out... I'll see what I can. My main concern is not breaking existing functionality. But it's better to keep code in a single place rather than having multiple forks if possible.

@mescanne mescanne merged commit 100bba8 into GoogleCloudPlatform:master Apr 4, 2024
3 checks passed
@mescanne
Copy link
Collaborator

mescanne commented Apr 4, 2024

Oh, drat, and I forgot to merge your changes before the release!

@mfridman
Copy link
Contributor Author

mfridman commented Apr 5, 2024

No worries, appreciate you still maintaining the project and willing to make forward progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants