-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(deps): update dependency isort to v7 #13599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency isort to v7 #13599
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to upgrade the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates isort
to version 7.0.0. However, this new version has stricter Python version requirements (>=3.10) which are not correctly handled in the updated requirements.txt
. The current changes will cause dependency installation to fail on Python versions 3.8 and older. I've provided a suggestion to fix this critical issue.
isort==6.0.0; python_version > "3.9" | ||
isort==5.13.2; python_version <= "3.8" | ||
isort==7.0.0; python_version > "3.9" | ||
isort==7.0.0; python_version <= "3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isort
version 7.0.0 requires Python 3.10 or newer. Specifying it for Python versions <= "3.8"
will cause installation to fail on those environments. You should keep using isort
v5 for older Python versions.
As a side note, neither the old nor the new configuration specifies an isort
version for Python 3.9. You may want to add a line for it, for example: isort==6.0.0; python_version == "3.9"
.
isort==5.13.2; python_version <= "3.8"
This PR contains the following updates:
==5.13.2
->==7.0.0
==6.0.0
->==7.0.0
Release Notes
PyCQA/isort (isort)
v7.0.0
Compare Source
Changes
💥 Breaking Changes
🚀 Features
🪲 Fixes
3.14
and fix any bugs (#2425) @DanielNoord👷 Continuous Integration
ruff
instead ofblack
(#2432) @DanielNoordruff
(#2431) @DanielNoord📦 Dependencies
v6.1.0
Compare Source
v6.0.1
Compare Source
v6.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.