Skip to content

Commit

Permalink
Merge pull request #146 from GoogleCloudPlatform/fix_typos
Browse files Browse the repository at this point in the history
Correct minor typos in docs
  • Loading branch information
jonchenn authored Nov 21, 2023
2 parents 9ec885b + da43e6b commit a73f341
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ If you are looking for the general development guide for the generated code from

## Bug Reports

If you encounter any issues or bugs, please [file a new Github Issue](https://github.com/GoogleCloudPlatform/solutions-builder/issues/new).
If you encounter any issues or bugs, please [file a new GitHub Issue](https://github.com/GoogleCloudPlatform/solutions-builder/issues/new).

- The Google team will triage the issues and will reply to your issues shortly.

Expand Down
2 changes: 1 addition & 1 deletion docs/CLI_USAGE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Solution Builder CLI Usage
# Solutions Builder CLI Usage

## Global Variables

Expand Down
2 changes: 1 addition & 1 deletion docs/INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ Once updated, open the browser to the Cloud Run service's URL, and you'll see th

An infra component is nothing but another component. Some component contains just infra pieces in `terraform/modules` or `terraform/stages` folders. Other component may contain both `component/service_name` as a microservice **AND** required infra resources in `terraform/stages`.

To add an infra component, run the same command like adding a regular component.
To add an infra component, run the same command as adding a regular component.
```
sb components add [COMPONENT_NAME]
```
Expand Down
4 changes: 2 additions & 2 deletions e2e/template_e2e_tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This doc covers the setup and steps required for running e2e tests for Template.

## Setup

> Currently, we run into issues of creating a brand new project for every e2e test. Hence we use one static project for e2e testing with resources clean up.
> Currently, we run into issues of creating a brand-new project for every e2e test. Hence, we use one static project for e2e testing with resources clean up.
- Create an org-level service account as e2e-runner:
> This service account can be created separately under another GCP project with granted permissions on the org-level.
Expand Down Expand Up @@ -75,7 +75,7 @@ This doc covers the setup and steps required for running e2e tests for Template.
bash ./e2e/template_e2e_tests/run_e2e_test.sh
```

## Run E2E tests with Github Actions for E2E tests
## Run E2E tests with GitHub Actions for E2E tests

Add the following secrets to the `e2e` group:

Expand Down

0 comments on commit a73f341

Please sign in to comment.