Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common module to eliminate IDE warnings #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update common module to eliminate IDE warnings #130

wants to merge 1 commit into from

Conversation

lavjain
Copy link
Collaborator

@lavjain lavjain commented Sep 27, 2023

Also use the latest python modules for requirements.txt

jonchenn
jonchenn requested changes Sep 28, 2023
View reviewed changes
solutions_builder/template_root/components/{{'common' if has_common}}/src/common/models/user.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not adding this data model in the SB. This is for CSS, not for the SB structure.

..._builder/template_root/components/{{'common' if has_common}}/src/common/models/base_model.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this copied from the CSS repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonchenn jonchenn jonchenn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavjain @jonchenn