Added sample unit test cases (#694)

* unit tests fixed and created selenium test framework

* removed selenium test files

* added github workflow

* added unit tests to workspace component

* added unit tests

* added  a test

* minor changes

* minor changes

* modified tab label

* minor change

* addressed comments

* ng build files

ui/src/app/components/add-index-form/add-index-form.component.spec.ts

@@ -1,36 +1,198 @@
 import { HttpClientModule } from '@angular/common/http';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { ReactiveFormsModule } from '@angular/forms';
-import { MatButtonModule } from '@angular/material/button';
-import { MatCardModule } from '@angular/material/card';
-import { MatDialogModule } from '@angular/material/dialog';
+import { FormArray, FormBuilder, ReactiveFormsModule } from '@angular/forms';
 import { MatFormFieldModule } from '@angular/material/form-field';
 import { MatInputModule } from '@angular/material/input';
 import { MatSelectModule } from '@angular/material/select';
 import { MatSnackBarModule } from '@angular/material/snack-bar';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
-
+import { of } from 'rxjs';
+import IConv from 'src/app/model/conv';
+import IRule from 'src/app/model/rule';
+import { ConversionService } from 'src/app/services/conversion/conversion.service';
+import { DataService } from 'src/app/services/data/data.service';
+import { SidenavService } from 'src/app/services/sidenav/sidenav.service';
+import mockIConv from 'src/mocks/conv';
 import { AddIndexFormComponent } from './add-index-form.component';
 
 describe('AddIndexFormComponent', () => {
   let component: AddIndexFormComponent;
   let fixture: ComponentFixture<AddIndexFormComponent>;
+  let dataServiceSpy: jasmine.SpyObj<DataService>;
+  let sidenavServiceSpy: jasmine.SpyObj<SidenavService>;
+  let fb: FormBuilder;
+  let conversionServiceSpy: jasmine.SpyObj<ConversionService>;
 
   beforeEach(async () => {
+    dataServiceSpy = jasmine.createSpyObj('DataService', ['conv', 'applyRule', 'dropRule']);
+    sidenavServiceSpy = jasmine.createSpyObj('SidenavService', [
+      'sidenavAddIndexTable',
+      'setSidenavAddIndexTable',
+      'closeSidenav',
+      'displayRuleFlag',
+      'ruleData',
+    ]);
+    conversionServiceSpy = jasmine.createSpyObj('ConversionService', [
+      'getTableIdFromSpName',
+      'getColIdFromSpannerColName',
+    ]);
+
     await TestBed.configureTestingModule({
-      declarations: [ AddIndexFormComponent ],
-      imports: [ReactiveFormsModule, HttpClientModule, MatSnackBarModule, MatSelectModule, BrowserAnimationsModule, MatFormFieldModule, MatInputModule]
+      declarations: [AddIndexFormComponent],
+      imports: [ReactiveFormsModule, HttpClientModule, MatSnackBarModule, MatSelectModule, BrowserAnimationsModule, MatFormFieldModule, MatInputModule],
+      providers: [
+        FormBuilder,
+        { provide: DataService, useValue: dataServiceSpy },
+        { provide: SidenavService, useValue: sidenavServiceSpy },
+        { provide: ConversionService, useValue: conversionServiceSpy },
+      ],
     })
-    .compileComponents();
+      .compileComponents();
+
+    fb = TestBed.inject(FormBuilder);
+
+    // Added the spy methods in beforeEach block because these are referred in the ngOnInit function
+    conversionServiceSpy.getColIdFromSpannerColName.withArgs(jasmine.any(String),jasmine.any(String),jasmine.objectContaining<IConv>({})).and.returnValue("TestId")
+    conversionServiceSpy.getTableIdFromSpName.withArgs(jasmine.any(String), jasmine.objectContaining<IConv>({})).and.returnValue("t1")
+    dataServiceSpy.conv = of(mockIConv);
+    sidenavServiceSpy.sidenavAddIndexTable = of("t1");
+    sidenavServiceSpy.displayRuleFlag = of(true)
+    sidenavServiceSpy.ruleData = of()
   });
 
   beforeEach(() => {
     fixture = TestBed.createComponent(AddIndexFormComponent);
     component = fixture.componentInstance;
+    component.addIndexForm = fb.group({
+      tableName: [''],
+      indexName: ['', []],
+      ColsArray: fb.array([]),
+    });
     fixture.detectChanges();
   });
 
   it('should create', () => {
     expect(component).toBeTruthy();
   });
+
+  it('should render ngOnInit and all dependent services correctly', () => {
+    const addIndexRule: IRule = {
+      Id: "r1",
+      Name: "x1",
+      ObjectType: "Table",
+      Type: "add_index",
+      Enabled: true,
+      Data: {
+        Id: "ind1",
+        Name: "index1",
+        TableId: "t1",
+        Keys: [
+          {
+            ColId: "c1",
+            Order: 1,
+            Desc: false,
+          }
+        ]
+      }
+    }
+    sidenavServiceSpy.ruleData = of(addIndexRule)
+    component.ngOnInit()
+    const columnName = mockIConv.SpSchema[addIndexRule.Data.TableId]?.ColDefs[addIndexRule.Data.Keys[0].ColId].Name;
+    expect(component.ColsArray.length).toBe(1);
+    expect(component.ColsArray.at(0).value.columnName).toEqual(columnName);
+    expect(component.addIndexForm.controls['tableName'].value).toEqual(mockIConv.SpSchema[addIndexRule.Data.TableId].Name);
+    expect(component.addIndexForm.controls['indexName'].value).toEqual(addIndexRule.Data.Name)
+    expect(component.addIndexForm.status).toEqual("DISABLED");
+  });
+
+  it('should add a new column form', () => {
+    component.addNewColumnForm();
+    expect(component.ColsArray.length).toBe(1);
+  });
+
+  it('should remove a column form', () => {
+    component.addNewColumnForm();
+    component.addNewColumnForm();
+    component.removeColumnForm(1);
+    expect(component.ColsArray.length).toBe(1);
+  });
+
+  it('should reset rule type', () => {
+    spyOn(component.resetRuleType, 'emit');
+    component.resetRuleType.emit('');
+    expect(component.resetRuleType.emit).toHaveBeenCalledWith('');
+  });
+
+  it('should set column arrays for view rules', () => {
+    const tableId = 't1';
+    const ruleData = {
+      Keys: [
+        {
+          ColId: 'c1',
+          Desc: false,
+          Order: 1,
+        },
+      ],
+    };
+    component.setColArraysForViewRules(tableId, ruleData.Keys);
+    const columnName = mockIConv.SpSchema[tableId]?.ColDefs[ruleData.Keys[0].ColId].Name;
+    expect(component.ColsArray.length).toBe(1);
+    expect(component.ColsArray.at(0).value.columnName).toEqual(columnName);
+  });
+
+  it('should clear column arrays for empty data', () => {
+    const tableId = 't1';
+    component.setColArraysForViewRules(tableId, undefined);
+    expect(component.ColsArray.length).toBe(0);
+  });
+
+  it('should update common columns', () => {
+    component.totalColumns = ['Column1', 'Column2', 'Column3'];
+    component.addIndexForm = fb.group({
+      ColsArray: fb.array([
+        fb.group({ columnName: 'Column1', sort: 'true' }),
+        fb.group({ columnName: 'Column3', sort: 'false' }),
+      ]),
+    });
+    component.updateCommonColumns();
+    expect(component.commonColumns).toEqual(['Column2']);
+  });
+
+  it('should select table change', () => {
+    const tableName = 'table1';
+    component.selectedTableChange(tableName);
+    expect(component.totalColumns).toEqual(['column1']);
+    expect(component.ColsArray.length).toBe(0);
+    expect(component.commonColumns).toEqual(['column1']);
+    expect(component.addColumnsList).toEqual([]);
+  });
+
+  it('should delete a rule', () => {
+    component.ruleId = 'sampleRuleId';
+    component.deleteRule();
+    expect(dataServiceSpy.dropRule).toHaveBeenCalledWith('sampleRuleId');
+    expect(sidenavServiceSpy.setSidenavAddIndexTable).toHaveBeenCalledWith('');
+    expect(sidenavServiceSpy.closeSidenav).toHaveBeenCalled();
+  });
+
+  it('should add an index and apply a rule', () => {
+    // Mock form values
+    component.addIndexForm = fb.group({
+      tableName: 'table1',
+      indexName: 'ind1',
+      ColsArray: fb.array([
+        fb.group({ columnName: 'column1', sort: 'true' }),
+      ]),
+    });
+    const tableNameValue = component.addIndexForm.get('tableName')?.value;
+    const colsArray = component.addIndexForm.get('ColsArray') as FormArray;
+    const columnNameValue = colsArray.at(0)?.get('columnName')?.value;
+    component.addIndex();
+    expect(conversionServiceSpy.getTableIdFromSpName).toHaveBeenCalledWith(tableNameValue, component.conv);
+    expect(conversionServiceSpy.getColIdFromSpannerColName).toHaveBeenCalledWith(columnNameValue, 't1', component.conv);
+    expect(dataServiceSpy.applyRule).toHaveBeenCalled();
+    expect(sidenavServiceSpy.setSidenavAddIndexTable).toHaveBeenCalledWith('');
+    expect(sidenavServiceSpy.closeSidenav).toHaveBeenCalled();
+  });
+
 });

ui/src/app/components/workspace/workspace.component.html

@@ -76,7 +76,7 @@
     >
       <app-object-detail
         [currentObject]="currentObject"
-        (updateSidebar)="reRenderSidebar()"
+        (updateSidebar)="reRenderObjectExplorerSpanner()"
         [tableData]="tableData"
         [indexData]="indexData"
         [typeMap]="typeMap"