fix(spanner): View assessment does not show detailed report and the download report functionality was not working #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratickchokhani
commented
Feb 6, 2025
•
pratickchokhani
commented
- ReportGenerator was null as the respective interface was not assigned.
- If any report has no issues, then all the issues was being reset.
…ownload report functionality was not working: - ReportGenerator was null as the respective interface was not assigned. - If any report ha no issues, then all the issues was being reset.
pratickchokhani
requested review from
darshan-sj and
VardhanThigle
and removed request for
a team
…latform#995) * added missing parentheses for UI * added the UT for parentheses method * added test cases * updated parenthesis logic to handle more cases. (GoogleCloudPlatform#80) * updated the func to handle more cases * udpated the test cases --------- Co-authored-by: Vivek Yadav <[email protected]> * added the test case with space --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
…ages (GoogleCloudPlatform#998) * Update installation instructions * Formatting * Formatting * Corrected the instructions * Corrected node version
* added the front fixes (GoogleCloudPlatform#67) 1. resolve the default value issue while save 2. error handling for verification api 3. drop column issue 4. updated the build Co-authored-by: Vivek Yadav <[email protected]> * Resolve the backend related issue (GoogleCloudPlatform#68) * Resolve the backend related issue 1. Added dropping invalid check constraints 2. Error handling for verification api * added the space * updated the documentation for check constraints (GoogleCloudPlatform#69) * updated the documentation for check constraints * updated the screenshots for issues * fix the summary --------- Co-authored-by: Vivek Yadav <[email protected]> --------- Co-authored-by: Vivek Yadav <[email protected]> * Changed warning msg to error on on prepare migration (GoogleCloudPlatform#79) * Changed warning msg to error on on prepare migration * remove duplicate issue * updated the build files * updated the comment --------- Co-authored-by: Vivek Yadav <[email protected]> * seperated the generic errors for showing as warning and error * integrated the verification api on session cmd and updated the doc (GoogleCloudPlatform#81) * integrated the verification api on session cmd and updated the doc 1. Added the verification api when session cmd is used via a cli 2. Updated the document with the latest change. * Update mysql.md --------- Co-authored-by: Vivek Yadav <[email protected]> * comment is addressed (GoogleCloudPlatform#82) * comment is addressed * revert the changes --------- Co-authored-by: Vivek Yadav <[email protected]> --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
* fixed the pg bug * updated the UT * refactor the code --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
…latform#992) Co-authored-by: Vardhan Vinay Thigle <[email protected]>
…#993) Co-authored-by: Vardhan Vinay Thigle <[email protected]>
* Changes * changes * changes * changes * changes * changes * changes * changes * changes
…#1003) * Fix: bug fixes related to refresh client and error handling (GoogleCloudPlatform#85) * fix: bug fixes 1. added refresh client on prepare migration click 2. error handling at load of schema --------- Co-authored-by: Vivek Yadav <[email protected]> * query change * fix incorrect query * Align the query (GoogleCloudPlatform#87) * Align the query * Update infoschema.go --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: taherkl <[email protected]>
* changes * changes
… (GoogleCloudPlatform#1005) * Fix: for the session flag added the error handling * updated the log message --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
bharadwaj-aditya
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.