-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the UI test files #648
Merged
shreyakhajanchi
merged 11 commits into
GoogleCloudPlatform:master
from
shreyakhajanchi:ui-test-framework
Nov 22, 2023
Merged
Updated the UI test files #648
shreyakhajanchi
merged 11 commits into
GoogleCloudPlatform:master
from
shreyakhajanchi:ui-test-framework
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we get into the details of the PR, can we add the following -
|
manitgupta
reviewed
Oct 4, 2023
shreyakhajanchi
force-pushed
the
ui-test-framework
branch
from
October 10, 2023 05:11
1d0e557
to
b2e5814
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
- Coverage 54.25% 48.39% -5.86%
==========================================
Files 65 117 +52
Lines 12355 15780 +3425
Branches 0 468 +468
==========================================
+ Hits 6703 7637 +934
- Misses 5185 7657 +2472
- Partials 467 486 +19
|
ui/src/app/components/direct-connection/direct-connection.component.spec.ts
Show resolved
Hide resolved
bharadwaj-aditya
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shreyakhajanchi
force-pushed
the
ui-test-framework
branch
from
November 22, 2023 12:58
0e5f33a
to
be4c63f
Compare
shreyakhajanchi
merged commit Nov 22, 2023
b8e56a6
into
GoogleCloudPlatform:master
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated test files for all the UI components for successful run.
Command executed:
ng test