-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubsub notificaiton setup for low downtime migration #656
Pubsub notificaiton setup for low downtime migration #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the flow reads off for me. We need to refactor and name methods according to what they are doing.
Each method should follow a single responsibility principle and do one thing.
We also seem to have implemented bucket handling for multiple shards. We need to think this through - for example, how does having everything in bucket affect retries for a subset of shards. Are there any throughput constraints introduced?
These detail needs to be captured in the design.
ui/src/app/components/prepare-migration/prepare-migration.component.html
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 54.62% 54.42% -0.20%
==========================================
Files 65 65
Lines 12272 12317 +45
==========================================
Hits 6703 6703
- Misses 5102 5147 +45
Partials 467 467
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add to the read-me (or any suitable place in the documentation) that (something on the lines of below):
- smt will create pub/sub topics for each bucket.
- Users will need to give permissions to the gcs service agent (more details on the lines of reporting-changes Unfortunately we can't link to the subsection or say step-5 as the numbers could change.)
- [less important] The avro files would be copied to "/data/" folder within the root path specified by the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good now, thanks for the updates.
Documentation changes are missing. We need to update both the existing images and text about how the pipeline works, along with new permissions and pre-requisites required to run HB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Documentation changes preview -- https://darshan-sj.github.io/harbourbridge/ |
Creates pubsub topic, subscription and notification for each migration and for each Datashard(physical shard) in case of sharded migration.
Tested: