Add Support for Check Constraint - Frontend code changes #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taherkl
commented
Dec 2, 2024
•
taherkl
commented
- Users can view details of check constraints in the Check Constraint tab.
- Users will be able to add, delete, and edit check constraints.
- Deletion of a column is restricted if it is used in a check constraint.
- Validation is performed to prevent adding duplicate expressions or constraint names in check constraints.
- Check constraints have been incorporated into the Spanner query.
- All other validations utilize the expression API.
- Tests pass
- Appropriate changes to README are included in PR
Backend Support for Check Constraint
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…nstraint name is empty
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
ui/src/app/components/object-detail/object-detail.component.html
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Dec 5, 2024
ui/src/app/components/object-detail/object-detail.component.html
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Dec 5, 2024
ui/src/app/components/object-detail/object-detail.component.html
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Dec 5, 2024
ui/src/app/components/object-detail/object-detail.component.html
Outdated
Show resolved
Hide resolved
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
asthamohta
reviewed
Dec 5, 2024
* Add the UI changes for supporting check constraints --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: taherkl <[email protected]>
akashthawaitcc
force-pushed
the
support-check-constraint-frontend
branch
from
93872ca to
9fd86eb
Compare
VivekY1098
force-pushed
the
support-check-constraint-frontend
branch
2 times, most recently
from
9ae7e36 to
099e79c
Compare
akashthawaitcc
force-pushed
the
support-check-constraint-frontend
branch
from
099e79c to
e38a37d
Compare
taherkl
requested review from
asthamohta and
bharadwaj-aditya
and removed request for
a team
taherkl
force-pushed
the
support-check-constraint-frontend
branch
2 times, most recently
from
9028e0f to
635dfbb
Compare
Backend Support for Check Constraint renamed function name to formatCheckConstraints and added check if constraint name is empty fixed PR comments fix: added regular exprression to match the exact column Added test case for the column rename for check constraint reverted white spaces reverted white spaces nit: doesCheckConstraintNameExist moved regex globally modify the query to fetch the check constraint added the verification api integration and struct changes added partial unit test of verify check constraint expression refactored expression verfication api mock Test added for verification api
* Check constraint backend (#9) Backend Support for Check Constraint * update api * fix PR comment * remove api call to while validating constraints * Fixed db collation regex to remove collation name from the results * renamed function name to formatCheckConstraints and added check if constraint name is empty * fixed PR comments * added test case for the empty check constraint name * fix: added regular exprression to match the exact column * fix: added regular expression to replace table name * Added test case for the column rename for check constraint * 1. Refactored GetConstraint function 2. Fixed inforschema unit tests * added comment at handling case for check constraints * reverted white spaces * reverted white spaces * nit: doesCheckConstraintNameExist * added comments for doesCheckConstraintNameExist * PR and UT fixes * fix UT * UT fix * Removed isCheckConstraintsTablePresent function * moved regex globally * Fix UT * fixed UT * fixed handling of the constraints * removed unused function * added unit tests for incompatable name * Combined unit tests * added test case for the renaming column having substring of other column * added the query changes which return distinct value --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Fixed unit test and code refactor removed node dependencies added dump flow
* Add the UI changes for supporting check constraints --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: taherkl <[email protected]> address the comment address the comment 1.Modify the checkIfCcColumn to handle pk and check constraint fixed regular expression for check constraints name remove the node-sql-parser package resolve the duplicate issue
Backend Support for Check Constraint renamed function name to formatCheckConstraints and added check if constraint name is empty fixed PR comments added test case for the empty check constraint name fix: added regular exprression to match the exact column fix: added regular expression to replace table name Added test case for the column rename for check constraint added comment at handling case for check constraints reverted white spaces reverted white spaces moved regex globally modify the query to fetch the check constraint added the verification api integration and struct changes added partial unit test of verify check constraint expression refactored expression verfication api mock Test added for verification api
* Check constraint backend (#9) Backend Support for Check Constraint * update api * fix PR comment * remove api call to while validating constraints * Fixed db collation regex to remove collation name from the results * renamed function name to formatCheckConstraints and added check if constraint name is empty * fixed PR comments * added test case for the empty check constraint name * fix: added regular exprression to match the exact column * fix: added regular expression to replace table name * Added test case for the column rename for check constraint * 1. Refactored GetConstraint function 2. Fixed inforschema unit tests * added comment at handling case for check constraints * reverted white spaces * reverted white spaces * nit: doesCheckConstraintNameExist * added comments for doesCheckConstraintNameExist * PR and UT fixes * fix UT * UT fix * Removed isCheckConstraintsTablePresent function * moved regex globally * Fix UT * fixed UT * fixed handling of the constraints * removed unused function * added unit tests for incompatable name * Combined unit tests * added test case for the renaming column having substring of other column * added the query changes which return distinct value --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> fixed unit tests front-end ut fixed remove unwanted code removed node sql parser import removed node dependencies rename handler added the generation of constraint name added dump flow Feat/fe check contraints (#10) * Add the UI changes for supporting check constraints --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: taherkl <[email protected]> address the comment address the comment 1.Modify the checkIfCcColumn to handle pk and check constraint
taherkl
force-pushed
the
support-check-constraint-frontend
branch
from
635dfbb to
1157b86
Compare
PR comment fixes and feedback changes
|
Closing this PR as opened two seperate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.