Documentation for check constraints #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with master
…INTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
1. added documentation for check constraints
akashthawaitcc
requested review from
asthamohta and
VardhanThigle
and removed request for
a team
asthamohta
reviewed
Jan 6, 2025
asthamohta
reviewed
Jan 6, 2025
* formatting changes * Check constraint doc cmt (#37) * added ss for issues also * updated the text * updated the text * Update mysql.md * updated the text --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Akash Thawait <[email protected]> --------- Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
asthamohta
reviewed
Jan 8, 2025
akashthawaitcc
force-pushed
the
checkconstraints_documentation
branch
from
f9eefa0 to
257ee3d
Compare
akashthawaitcc
force-pushed
the
checkconstraints_documentation
branch
from
257ee3d to
fc8774d
Compare
* formatting changes * added ss for issues also * updated the text * updated the text * Update mysql.md * updated the text * updated the faq --------- Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
asthamohta
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
==========================================
- Coverage 46.72% 46.72% -0.01%
==========================================
Files 169 169
Lines 22810 22810
Branches 559 559
==========================================
- Hits 10659 10657 -2
- Misses 11546 11548 +2
Partials 605 605
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for check constraints.
https://ollionorg.github.io/spanner-migration-tool-fork/