Replace ReadOnlyTransaction() with Single() #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asthamohta
approved these changes
Jan 7, 2025
akashthawaitcc
added a commit
to ollionorg/spanner-migration-tool-fork
that referenced
this pull request
Jan 7, 2025
…#35) Co-authored-by: Manit Gupta <[email protected]>
akashthawaitcc
added a commit
to ollionorg/spanner-migration-tool-fork
that referenced
this pull request
Jan 7, 2025
* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]>
asthamohta
pushed a commit
that referenced
this pull request
Jan 7, 2025
* UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <[email protected]> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]>
akashthawaitcc
added a commit
to ollionorg/spanner-migration-tool-fork
that referenced
this pull request
Jan 8, 2025
* feat: default values final PR (GoogleCloudPlatform#976) * changes * changes * changes * changes * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- Co-authored-by: Vivek Yadav <[email protected]> * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- Co-authored-by: Vivek Yadav <[email protected]> * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- Co-authored-by: Vivek Yadav <[email protected]> * fixed if condition --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <[email protected]> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Astha Mohta <[email protected]> Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]>
akashthawaitcc
added a commit
to ollionorg/spanner-migration-tool-fork
that referenced
this pull request
Jan 8, 2025
* Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <[email protected]> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Manit Gupta <[email protected]> Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]>
akashthawaitcc
added a commit
to ollionorg/spanner-migration-tool-fork
that referenced
this pull request
Jan 8, 2025
* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> * sync upstream/master (#42) * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <[email protected]> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Manit Gupta <[email protected]> Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]>
bharadwaj-aditya
pushed a commit
that referenced
this pull request
Jan 17, 2025
* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (#984) (#35) Co-authored-by: Manit Gupta <[email protected]> * sync upstream/master (#42) * Replace ReadOnlyTransaction() with Single() (#984) * UI changes for check constraint support (#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <[email protected]> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Manit Gupta <[email protected]> Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * added updated build file --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]>
akashthawaitcc
added a commit
to ollionorg/spanner-migration-tool-fork
that referenced
this pull request
Jan 23, 2025
* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> * sync upstream/master (#42) * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <[email protected]> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]> --------- Co-authored-by: Manit Gupta <[email protected]> Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> * updated the build and resolve the issue 1. verify api issue 2. drop column issue 3. updated the build * updated the build --------- Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: taherkl <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Manit Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During mocking the
Single()method of the client library, we used theReadOnlyTransaction()method to return an instance of a ReadOnlyTransaction. This is different from theReadOnlyTransactionobject that gets returned from theSingle()method, which is more suited to single use transactions that we use in the expressions API for verification.This caused the nature of the ReadOnlyTransactions being used to change from being
SingleUseto non-SingleUse, which would then cause session leaks since they were not automatically getting cleaned up.Using
Single()fixes the session leak, and has been validated by running 20K CHECK constraint validations.