Fix build on Node >= 12 #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
This seems like a workaround. Have you evaluated the effort of fixing #91 properly? Does it require moving to a new version of gulp, and a lot of re-write? |
|
Yes this is a workaround. A proper fix would indeed require a gulp upgrade to v4 : upgrade the version, changing the gulpfile to a new format and probably also upgrade some plugins. I haven't used gulp for many years so someone might be better fitted to do this upgrade. |
|
For info, I was able to upgrade gulp and node with a few minor changes psithur@a0ff987 |
|
@xlfe would you mind opening a Pull Request with this upgrade to gulp 4? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary solution for #91 until Gulp is upgraded to v4