chore: manual linting corrections to pass flake8 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasnt
commented
Oct 25, 2024
| @@ -11,5 +11,3 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from .app import EMBEDDING_MODEL_NAME, init_app, parse_config | |||
There was a problem hiding this comment.
This was removed because linting, but this breaks the process because of current imports in run_app
glasnt
commented
Oct 25, 2024
| @@ -11,5 +11,3 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
There was a problem hiding this comment.
Based on previous, at a guess this is what was meant? (Based on a similar pattern in src/retrieval_service/datastore/init.py, datastore/providers/init.py)
Suggested change
| # limitations under the License. | |
| # limitations under the License. | |
| from .app import EMBEDDING_MODEL_NAME, init_app, parse_config | |
| __ALL__ = [EMBEDDING_MODEL_NAME, init_app, parse_config] |
glasnt
commented
Oct 25, 2024
| @@ -11,5 +11,3 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
There was a problem hiding this comment.
As above, presumed import pattern to help with importing but also pass linting
Suggested change
| # limitations under the License. | |
| # limitations under the License. | |
| from .models import Airport, Amenity, Flight, Ticket | |
| __ALL__ = [Airport, Amenity, Flight, Ticket |
kweinmeister
approved these changes
Nov 19, 2024
|
Major codebase drift, many conflicting files, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black, manual "re-wrapping" on prompts, and other manual cleanup steps.
Not tested for functional equivelence.