Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Fix ancestry_path for top-level resources #4

Open
nstogner opened this issue Apr 1, 2019 · 10 comments
Open

Fix ancestry_path for top-level resources #4

nstogner opened this issue Apr 1, 2019 · 10 comments
Labels
persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work

Comments

@nstogner
Copy link

nstogner commented Apr 1, 2019

Currently asset.ancestry_path assumes the resource lives within a project. This does not work for folders, etc.

@nstogner
Copy link
Author

nstogner commented Apr 4, 2019

Examples ancestry_path for top-level resources:

organization: organization/{org_id}
folder: organzation/{org_id}/folder/{folder}
project: organzation/{org_id}/folder/{folder}/project/{project}

@nstogner
Copy link
Author

nstogner commented Apr 4, 2019

Strategy: Move the calculation ancestry_path upstream into the conversions library. See GoogleCloudPlatform/magic-modules#1620.

@nstogner
Copy link
Author

nstogner commented Apr 4, 2019

PS: Once 1620 (above) gets merged, we should be able to get rid of the internally defined Asset struct and use the one from the conversions library.

@melinath
Copy link
Member

melinath commented May 3, 2021

Closing - seems to be a duplicate of #5.

@melinath melinath closed this as completed May 3, 2021
@morgante morgante reopened this May 3, 2021
@morgante
Copy link
Contributor

morgante commented May 3, 2021

@melinath Last I checked, I think we still need a fix for this. In particular, if you are validating a google_folder resource it should return an ancestry_path of organzation/{org_id}/folder/{parent_folder}.

@melinath
Copy link
Member

melinath commented May 4, 2021

Whereas now I assume it includes the project as well? I was thinking of this as being a duplicate of #5 (and by extension of #206) but we could probably resolve it separately in the shorter term.

@melinath melinath added the bug Something isn't working label May 4, 2021
@morgante
Copy link
Contributor

morgante commented May 4, 2021

Right, I think now we use a nonsense project in the ancestry path (folders can't have projects as their parent).

This might be a dupe of #5, but since you closed both I think there was more detail here.

@suibinz

This comment has been minimized.

@melinath

This comment has been minimized.

@suibinz

This comment has been minimized.

@melinath melinath added persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work and removed bug Something isn't working labels Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work
Projects
None yet
Development

No branches or pull requests

4 participants