This repository has been archived by the owner on May 15, 2023. It is now read-only.
[WIP] Move ancestry logic upstream #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is related to an issue I am having with the target in my constraint for projects. It works well for other resources, but for projects to be correctly targeted by my constraint, I have to use oragnization/* as a target... Nothing else works. Is there anything I can do to help merge this PR? |
|
@AdrienWalkowiak Would you be able to pick up working on GoogleCloudPlatform/magic-modules#1620? @nstogner is no longer working on this project, so we just need someone to take over the PR. |
|
Given that the upstream pull request is closed without being merged, should this pull request be closed as well? |
|
Yes, I think this can be closed but I'd still like to upstream mappers: #103. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on GoogleCloudPlatform/magic-modules#1620.
Addresses #4 & #5.