This repository has been archived by the owner on May 15, 2023. It is now read-only.
add cfg.LoadAndValidate back #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morgante PTAL. Thank you. |
chrisst
reviewed
Nov 5, 2019
| cfg := &converter.Config{ | ||
| Project: project, | ||
| Credentials: credentials, | ||
| } | ||
| if !offline { |
There was a problem hiding this comment.
Could you just check for a nil config/client instead of needing to pass this boolean around?
There was a problem hiding this comment.
The client is cfg so it was not pass into this function. I am also very tempted to extract cfg construction out of this function but @morgante may know better if it is the right way.
morgante
approved these changes
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a break fix for #89 and #85 (comment)